2019-05-27 06:55:05 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
2009-04-23 18:10:43 +00:00
|
|
|
/*
|
|
|
|
* max1586.c -- Voltage and current regulation for the Maxim 1586
|
|
|
|
*
|
|
|
|
* Copyright (C) 2008 Robert Jarzmik
|
|
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/i2c.h>
|
|
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/regulator/driver.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2009-04-23 18:10:43 +00:00
|
|
|
#include <linux/regulator/max1586.h>
|
2014-08-31 19:10:51 +00:00
|
|
|
#include <linux/of_device.h>
|
|
|
|
#include <linux/regulator/of_regulator.h>
|
2009-04-23 18:10:43 +00:00
|
|
|
|
|
|
|
#define MAX1586_V3_MAX_VSEL 31
|
|
|
|
#define MAX1586_V6_MAX_VSEL 3
|
|
|
|
|
|
|
|
#define MAX1586_V3_MIN_UV 700000
|
|
|
|
#define MAX1586_V3_MAX_UV 1475000
|
|
|
|
|
|
|
|
#define MAX1586_V6_MIN_UV 0
|
|
|
|
#define MAX1586_V6_MAX_UV 3000000
|
|
|
|
|
|
|
|
#define I2C_V3_SELECT (0 << 5)
|
|
|
|
#define I2C_V6_SELECT (1 << 5)
|
|
|
|
|
2009-05-28 05:15:16 +00:00
|
|
|
struct max1586_data {
|
|
|
|
struct i2c_client *client;
|
|
|
|
|
|
|
|
/* min/max V3 voltage */
|
2009-05-28 19:00:03 +00:00
|
|
|
unsigned int min_uV;
|
|
|
|
unsigned int max_uV;
|
2009-05-28 05:15:16 +00:00
|
|
|
|
2012-11-29 05:19:43 +00:00
|
|
|
unsigned int v3_curr_sel;
|
|
|
|
unsigned int v6_curr_sel;
|
2009-05-28 05:15:16 +00:00
|
|
|
};
|
|
|
|
|
2012-06-04 04:56:58 +00:00
|
|
|
/*
|
|
|
|
* V6 voltage
|
|
|
|
* On I2C bus, sending a "x" byte to the max1586 means :
|
|
|
|
* set V6 to either 0V, 1.8V, 2.5V, 3V depending on (x & 0x3)
|
|
|
|
* As regulator framework doesn't accept voltages to be 0V, we use 1uV.
|
|
|
|
*/
|
2013-03-30 05:57:29 +00:00
|
|
|
static const unsigned int v6_voltages_uv[] = { 1, 1800000, 2500000, 3000000 };
|
2012-06-04 04:56:58 +00:00
|
|
|
|
2009-04-23 18:10:43 +00:00
|
|
|
/*
|
|
|
|
* V3 voltage
|
|
|
|
* On I2C bus, sending a "x" byte to the max1586 means :
|
|
|
|
* set V3 to 0.700V + (x & 0x1f) * 0.025V
|
2009-05-28 05:15:16 +00:00
|
|
|
* This voltage can be increased by external resistors
|
|
|
|
* R24 and R25=100kOhm as described in the data sheet.
|
|
|
|
* The gain is approximately: 1 + R24/R25 + R24/185.5kOhm
|
2009-04-23 18:10:43 +00:00
|
|
|
*/
|
2012-11-29 05:19:43 +00:00
|
|
|
static int max1586_v3_get_voltage_sel(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max1586_data *max1586 = rdev_get_drvdata(rdev);
|
|
|
|
|
|
|
|
return max1586->v3_curr_sel;
|
|
|
|
}
|
|
|
|
|
2012-06-08 00:26:44 +00:00
|
|
|
static int max1586_v3_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
unsigned selector)
|
2009-04-23 18:10:43 +00:00
|
|
|
{
|
2009-05-28 05:15:16 +00:00
|
|
|
struct max1586_data *max1586 = rdev_get_drvdata(rdev);
|
|
|
|
struct i2c_client *client = max1586->client;
|
2012-11-29 05:19:43 +00:00
|
|
|
int ret;
|
2009-04-23 18:10:43 +00:00
|
|
|
u8 v3_prog;
|
|
|
|
|
|
|
|
dev_dbg(&client->dev, "changing voltage v3 to %dmv\n",
|
2012-06-08 00:26:44 +00:00
|
|
|
regulator_list_voltage_linear(rdev, selector) / 1000);
|
2009-04-23 18:10:43 +00:00
|
|
|
|
2012-06-08 00:26:44 +00:00
|
|
|
v3_prog = I2C_V3_SELECT | (u8) selector;
|
2012-11-29 05:19:43 +00:00
|
|
|
ret = i2c_smbus_write_byte(client, v3_prog);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
max1586->v3_curr_sel = selector;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int max1586_v6_get_voltage_sel(struct regulator_dev *rdev)
|
|
|
|
{
|
|
|
|
struct max1586_data *max1586 = rdev_get_drvdata(rdev);
|
|
|
|
|
|
|
|
return max1586->v6_curr_sel;
|
2009-04-23 18:10:43 +00:00
|
|
|
}
|
|
|
|
|
2012-06-04 04:58:24 +00:00
|
|
|
static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev,
|
|
|
|
unsigned int selector)
|
2009-04-23 18:10:43 +00:00
|
|
|
{
|
2012-11-29 05:19:43 +00:00
|
|
|
struct max1586_data *max1586 = rdev_get_drvdata(rdev);
|
|
|
|
struct i2c_client *client = max1586->client;
|
2009-04-23 18:10:43 +00:00
|
|
|
u8 v6_prog;
|
2012-11-29 05:19:43 +00:00
|
|
|
int ret;
|
2009-04-23 18:10:43 +00:00
|
|
|
|
|
|
|
dev_dbg(&client->dev, "changing voltage v6 to %dmv\n",
|
2012-06-04 04:58:24 +00:00
|
|
|
rdev->desc->volt_table[selector] / 1000);
|
2009-04-23 18:10:43 +00:00
|
|
|
|
2012-06-04 04:58:24 +00:00
|
|
|
v6_prog = I2C_V6_SELECT | (u8) selector;
|
2012-11-29 05:19:43 +00:00
|
|
|
ret = i2c_smbus_write_byte(client, v6_prog);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
max1586->v6_curr_sel = selector;
|
|
|
|
|
|
|
|
return 0;
|
2009-04-23 18:10:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back
|
|
|
|
* the set up value.
|
|
|
|
*/
|
2017-03-11 19:01:18 +00:00
|
|
|
static const struct regulator_ops max1586_v3_ops = {
|
2012-11-29 05:19:43 +00:00
|
|
|
.get_voltage_sel = max1586_v3_get_voltage_sel,
|
2012-06-08 00:26:44 +00:00
|
|
|
.set_voltage_sel = max1586_v3_set_voltage_sel,
|
2012-06-08 00:25:41 +00:00
|
|
|
.list_voltage = regulator_list_voltage_linear,
|
2012-06-08 00:26:44 +00:00
|
|
|
.map_voltage = regulator_map_voltage_linear,
|
2009-04-23 18:10:43 +00:00
|
|
|
};
|
|
|
|
|
2017-03-11 19:01:18 +00:00
|
|
|
static const struct regulator_ops max1586_v6_ops = {
|
2012-11-29 05:19:43 +00:00
|
|
|
.get_voltage_sel = max1586_v6_get_voltage_sel,
|
2012-06-04 04:58:24 +00:00
|
|
|
.set_voltage_sel = max1586_v6_set_voltage_sel,
|
2012-06-04 04:56:58 +00:00
|
|
|
.list_voltage = regulator_list_voltage_table,
|
2009-04-23 18:10:43 +00:00
|
|
|
};
|
|
|
|
|
2012-06-08 00:25:41 +00:00
|
|
|
static struct regulator_desc max1586_reg[] = {
|
2009-04-23 18:10:43 +00:00
|
|
|
{
|
|
|
|
.name = "Output_V3",
|
|
|
|
.id = MAX1586_V3,
|
|
|
|
.ops = &max1586_v3_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX1586_V3_MAX_VSEL + 1,
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
.name = "Output_V6",
|
|
|
|
.id = MAX1586_V6,
|
|
|
|
.ops = &max1586_v6_ops,
|
|
|
|
.type = REGULATOR_VOLTAGE,
|
|
|
|
.n_voltages = MAX1586_V6_MAX_VSEL + 1,
|
2012-06-04 04:56:58 +00:00
|
|
|
.volt_table = v6_voltages_uv,
|
2009-04-23 18:10:43 +00:00
|
|
|
.owner = THIS_MODULE,
|
|
|
|
},
|
|
|
|
};
|
|
|
|
|
2014-09-01 11:55:58 +00:00
|
|
|
static int of_get_max1586_platform_data(struct device *dev,
|
2014-08-31 19:10:51 +00:00
|
|
|
struct max1586_platform_data *pdata)
|
|
|
|
{
|
|
|
|
struct max1586_subdev_data *sub;
|
2014-11-03 14:40:40 +00:00
|
|
|
struct of_regulator_match rmatch[ARRAY_SIZE(max1586_reg)] = { };
|
2014-08-31 19:10:51 +00:00
|
|
|
struct device_node *np = dev->of_node;
|
|
|
|
int i, matched;
|
|
|
|
|
|
|
|
if (of_property_read_u32(np, "v3-gain",
|
|
|
|
&pdata->v3_gain) < 0) {
|
2017-07-18 21:43:26 +00:00
|
|
|
dev_err(dev, "%pOF has no 'v3-gain' property\n", np);
|
2014-08-31 19:10:51 +00:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
np = of_get_child_by_name(np, "regulators");
|
|
|
|
if (!np) {
|
|
|
|
dev_err(dev, "missing 'regulators' subnode in DT\n");
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(rmatch); i++)
|
|
|
|
rmatch[i].name = max1586_reg[i].name;
|
|
|
|
|
|
|
|
matched = of_regulator_match(dev, np, rmatch, ARRAY_SIZE(rmatch));
|
|
|
|
of_node_put(np);
|
|
|
|
/*
|
|
|
|
* If matched is 0, ie. neither Output_V3 nor Output_V6 have been found,
|
|
|
|
* return 0, which signals the normal situation where no subregulator is
|
|
|
|
* available. This is normal because the max1586 doesn't provide any
|
|
|
|
* readback support, so the subregulators can't report any status
|
|
|
|
* anyway. If matched < 0, return the error.
|
|
|
|
*/
|
|
|
|
if (matched <= 0)
|
|
|
|
return matched;
|
|
|
|
|
treewide: devm_kzalloc() -> devm_kcalloc()
The devm_kzalloc() function has a 2-factor argument form, devm_kcalloc().
This patch replaces cases of:
devm_kzalloc(handle, a * b, gfp)
with:
devm_kcalloc(handle, a * b, gfp)
as well as handling cases of:
devm_kzalloc(handle, a * b * c, gfp)
with:
devm_kzalloc(handle, array3_size(a, b, c), gfp)
as it's slightly less ugly than:
devm_kcalloc(handle, array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
devm_kzalloc(handle, 4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
Some manual whitespace fixes were needed in this patch, as Coccinelle
really liked to write "=devm_kcalloc..." instead of "= devm_kcalloc...".
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
expression HANDLE;
type TYPE;
expression THING, E;
@@
(
devm_kzalloc(HANDLE,
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
devm_kzalloc(HANDLE,
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression HANDLE;
expression COUNT;
typedef u8;
typedef __u8;
@@
(
devm_kzalloc(HANDLE,
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(char) * COUNT
+ COUNT
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
expression HANDLE;
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
expression HANDLE;
identifier SIZE, COUNT;
@@
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression HANDLE;
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression HANDLE;
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
devm_kzalloc(HANDLE,
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
expression HANDLE;
identifier STRIDE, SIZE, COUNT;
@@
(
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
devm_kzalloc(HANDLE,
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression HANDLE;
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE,
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
devm_kzalloc(HANDLE,
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression HANDLE;
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
devm_kzalloc(HANDLE, sizeof(THING) * C2, ...)
|
devm_kzalloc(HANDLE, sizeof(TYPE) * C2, ...)
|
devm_kzalloc(HANDLE, C1 * C2 * C3, ...)
|
devm_kzalloc(HANDLE, C1 * C2, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * E2
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- (E1) * (E2)
+ E1, E2
, ...)
|
- devm_kzalloc
+ devm_kcalloc
(HANDLE,
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-12 21:07:58 +00:00
|
|
|
pdata->subdevs = devm_kcalloc(dev,
|
|
|
|
matched,
|
|
|
|
sizeof(struct max1586_subdev_data),
|
|
|
|
GFP_KERNEL);
|
2014-08-31 19:10:51 +00:00
|
|
|
if (!pdata->subdevs)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
pdata->num_subdevs = matched;
|
|
|
|
sub = pdata->subdevs;
|
|
|
|
|
|
|
|
for (i = 0; i < matched; i++) {
|
|
|
|
sub->id = i;
|
|
|
|
sub->name = rmatch[i].of_node->name;
|
|
|
|
sub->platform_data = rmatch[i].init_data;
|
|
|
|
sub++;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-08-21 03:16:01 +00:00
|
|
|
static const struct of_device_id __maybe_unused max1586_of_match[] = {
|
2014-08-31 19:10:51 +00:00
|
|
|
{ .compatible = "maxim,max1586", },
|
|
|
|
{},
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, max1586_of_match);
|
|
|
|
|
2022-11-18 22:44:41 +00:00
|
|
|
static int max1586_pmic_probe(struct i2c_client *client)
|
2009-04-23 18:10:43 +00:00
|
|
|
{
|
2014-08-31 19:10:51 +00:00
|
|
|
struct max1586_platform_data *pdata, pdata_of;
|
2012-04-03 23:50:22 +00:00
|
|
|
struct regulator_config config = { };
|
2009-05-28 05:15:16 +00:00
|
|
|
struct max1586_data *max1586;
|
2014-08-31 19:10:51 +00:00
|
|
|
int i, id, ret;
|
|
|
|
const struct of_device_id *match;
|
|
|
|
|
|
|
|
pdata = dev_get_platdata(&client->dev);
|
|
|
|
if (client->dev.of_node && !pdata) {
|
|
|
|
match = of_match_device(of_match_ptr(max1586_of_match),
|
|
|
|
&client->dev);
|
|
|
|
if (!match) {
|
|
|
|
dev_err(&client->dev, "Error: No device match found\n");
|
|
|
|
return -ENODEV;
|
|
|
|
}
|
|
|
|
ret = of_get_max1586_platform_data(&client->dev, &pdata_of);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
pdata = &pdata_of;
|
|
|
|
}
|
2009-05-28 05:15:16 +00:00
|
|
|
|
2014-03-10 09:46:52 +00:00
|
|
|
max1586 = devm_kzalloc(&client->dev, sizeof(struct max1586_data),
|
2009-05-28 05:15:16 +00:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (!max1586)
|
2012-04-11 15:06:47 +00:00
|
|
|
return -ENOMEM;
|
2009-04-23 18:10:43 +00:00
|
|
|
|
2009-05-28 05:15:16 +00:00
|
|
|
max1586->client = client;
|
2009-04-23 18:10:43 +00:00
|
|
|
|
2012-04-11 15:06:47 +00:00
|
|
|
if (!pdata->v3_gain)
|
|
|
|
return -EINVAL;
|
|
|
|
|
2009-05-28 19:00:03 +00:00
|
|
|
max1586->min_uV = MAX1586_V3_MIN_UV / 1000 * pdata->v3_gain / 1000;
|
|
|
|
max1586->max_uV = MAX1586_V3_MAX_UV / 1000 * pdata->v3_gain / 1000;
|
2009-05-28 05:15:16 +00:00
|
|
|
|
2012-11-29 05:19:43 +00:00
|
|
|
/* Set curr_sel to default voltage on power-up */
|
|
|
|
max1586->v3_curr_sel = 24; /* 1.3V */
|
|
|
|
max1586->v6_curr_sel = 0;
|
|
|
|
|
2009-04-23 18:10:43 +00:00
|
|
|
for (i = 0; i < pdata->num_subdevs && i <= MAX1586_V6; i++) {
|
2014-03-10 08:32:44 +00:00
|
|
|
struct regulator_dev *rdev;
|
|
|
|
|
2009-04-23 18:10:43 +00:00
|
|
|
id = pdata->subdevs[i].id;
|
|
|
|
if (!pdata->subdevs[i].platform_data)
|
|
|
|
continue;
|
|
|
|
if (id < MAX1586_V3 || id > MAX1586_V6) {
|
|
|
|
dev_err(&client->dev, "invalid regulator id %d\n", id);
|
2013-09-04 05:37:55 +00:00
|
|
|
return -EINVAL;
|
2009-04-23 18:10:43 +00:00
|
|
|
}
|
2012-04-03 23:50:22 +00:00
|
|
|
|
2012-06-08 00:25:41 +00:00
|
|
|
if (id == MAX1586_V3) {
|
|
|
|
max1586_reg[id].min_uV = max1586->min_uV;
|
|
|
|
max1586_reg[id].uV_step =
|
|
|
|
(max1586->max_uV - max1586->min_uV) /
|
|
|
|
MAX1586_V3_MAX_VSEL;
|
|
|
|
}
|
|
|
|
|
2012-04-03 23:50:22 +00:00
|
|
|
config.dev = &client->dev;
|
|
|
|
config.init_data = pdata->subdevs[i].platform_data;
|
|
|
|
config.driver_data = max1586;
|
|
|
|
|
2014-03-10 08:32:44 +00:00
|
|
|
rdev = devm_regulator_register(&client->dev,
|
2013-09-04 05:37:55 +00:00
|
|
|
&max1586_reg[id], &config);
|
2014-03-10 08:32:44 +00:00
|
|
|
if (IS_ERR(rdev)) {
|
2009-04-23 18:10:43 +00:00
|
|
|
dev_err(&client->dev, "failed to register %s\n",
|
|
|
|
max1586_reg[id].name);
|
2014-03-10 08:32:44 +00:00
|
|
|
return PTR_ERR(rdev);
|
2009-04-23 18:10:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-08-06 05:33:15 +00:00
|
|
|
i2c_set_clientdata(client, max1586);
|
2009-04-23 18:10:43 +00:00
|
|
|
dev_info(&client->dev, "Maxim 1586 regulator driver loaded\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct i2c_device_id max1586_id[] = {
|
|
|
|
{ "max1586", 0 },
|
|
|
|
{ }
|
|
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(i2c, max1586_id);
|
|
|
|
|
|
|
|
static struct i2c_driver max1586_pmic_driver = {
|
2023-05-05 22:02:18 +00:00
|
|
|
.probe = max1586_pmic_probe,
|
2009-04-23 18:10:43 +00:00
|
|
|
.driver = {
|
|
|
|
.name = "max1586",
|
regulator: Set PROBE_PREFER_ASYNCHRONOUS for drivers that existed in 4.14
Probing of regulators can be a slow operation and can contribute to
slower boot times. This is especially true if a regulator is turned on
at probe time (with regulator-boot-on or regulator-always-on) and the
regulator requires delays (off-on-time, ramp time, etc).
While the overall kernel is not ready to switch to async probe by
default, as per the discussion on the mailing lists [1] it is believed
that the regulator subsystem is in good shape and we can move
regulator drivers over wholesale. There is no way to just magically
opt in all regulators (regulators are just normal drivers like
platform_driver), so we set PROBE_PREFER_ASYNCHRONOUS for all
regulators found in 'drivers/regulator' individually.
Given the number of drivers touched and the impossibility to test this
ahead of time, it wouldn't be shocking at all if this caused a
regression for someone. If there is a regression caused by this patch,
it's likely to be one of the cases talked about in [1]. As a "quick
fix", drivers involved in the regression could be fixed by changing
them to PROBE_FORCE_SYNCHRONOUS. That being said, the correct fix
would be to directly fix the problem that caused the issue with async
probe.
The approach here follows a similar approach that was used for the mmc
subsystem several years ago [2]. In fact, I ran nearly the same python
script to auto-generate the changes. The only thing I changed was to
search for "i2c_driver", "spmi_driver", and "spi_driver" in addition
to "platform_driver".
[1] https://lore.kernel.org/r/06db017f-e985-4434-8d1d-02ca2100cca0@sirena.org.uk
[2] https://lore.kernel.org/r/20200903232441.2694866-1-dianders@chromium.org/
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20230316125351.1.I2a4677392a38db5758dee0788b2cea5872562a82@changeid
Signed-off-by: Mark Brown <broonie@kernel.org>
2023-03-16 19:54:38 +00:00
|
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
2014-08-31 19:10:51 +00:00
|
|
|
.of_match_table = of_match_ptr(max1586_of_match),
|
2009-04-23 18:10:43 +00:00
|
|
|
},
|
|
|
|
.id_table = max1586_id,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int __init max1586_pmic_init(void)
|
|
|
|
{
|
|
|
|
return i2c_add_driver(&max1586_pmic_driver);
|
|
|
|
}
|
|
|
|
subsys_initcall(max1586_pmic_init);
|
|
|
|
|
|
|
|
static void __exit max1586_pmic_exit(void)
|
|
|
|
{
|
|
|
|
i2c_del_driver(&max1586_pmic_driver);
|
|
|
|
}
|
|
|
|
module_exit(max1586_pmic_exit);
|
|
|
|
|
|
|
|
/* Module information */
|
|
|
|
MODULE_DESCRIPTION("MAXIM 1586 voltage regulator driver");
|
|
|
|
MODULE_AUTHOR("Robert Jarzmik");
|
|
|
|
MODULE_LICENSE("GPL");
|