2020-05-12 23:54:17 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0+ */
|
2017-10-31 19:04:49 +00:00
|
|
|
/*
|
|
|
|
|
* Copyright (c) 2000-2002,2005 Silicon Graphics, Inc.
|
|
|
|
|
* Copyright (C) 2017 Oracle.
|
|
|
|
|
* All Rights Reserved.
|
|
|
|
|
*/
|
|
|
|
|
#ifndef __XFS_ERRORTAG_H_
|
|
|
|
|
#define __XFS_ERRORTAG_H_
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* error injection tags - the labels can be anything you want
|
|
|
|
|
* but each tag should have its own unique number
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#define XFS_ERRTAG_NOERROR 0
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_1 1
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_2 2
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_3 3
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_4 4
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_5 5
|
|
|
|
|
#define XFS_ERRTAG_IFLUSH_6 6
|
|
|
|
|
#define XFS_ERRTAG_DA_READ_BUF 7
|
|
|
|
|
#define XFS_ERRTAG_BTREE_CHECK_LBLOCK 8
|
|
|
|
|
#define XFS_ERRTAG_BTREE_CHECK_SBLOCK 9
|
|
|
|
|
#define XFS_ERRTAG_ALLOC_READ_AGF 10
|
|
|
|
|
#define XFS_ERRTAG_IALLOC_READ_AGI 11
|
|
|
|
|
#define XFS_ERRTAG_ITOBP_INOTOBP 12
|
|
|
|
|
#define XFS_ERRTAG_IUNLINK 13
|
|
|
|
|
#define XFS_ERRTAG_IUNLINK_REMOVE 14
|
|
|
|
|
#define XFS_ERRTAG_DIR_INO_VALIDATE 15
|
|
|
|
|
#define XFS_ERRTAG_BULKSTAT_READ_CHUNK 16
|
|
|
|
|
#define XFS_ERRTAG_IODONE_IOERR 17
|
|
|
|
|
#define XFS_ERRTAG_STRATREAD_IOERR 18
|
|
|
|
|
#define XFS_ERRTAG_STRATCMPL_IOERR 19
|
|
|
|
|
#define XFS_ERRTAG_DIOWRITE_IOERR 20
|
|
|
|
|
#define XFS_ERRTAG_BMAPIFORMAT 21
|
|
|
|
|
#define XFS_ERRTAG_FREE_EXTENT 22
|
|
|
|
|
#define XFS_ERRTAG_RMAP_FINISH_ONE 23
|
|
|
|
|
#define XFS_ERRTAG_REFCOUNT_CONTINUE_UPDATE 24
|
|
|
|
|
#define XFS_ERRTAG_REFCOUNT_FINISH_ONE 25
|
|
|
|
|
#define XFS_ERRTAG_BMAP_FINISH_ONE 26
|
|
|
|
|
#define XFS_ERRTAG_AG_RESV_CRITICAL 27
|
xfs: drop write error injection is unfixable, remove it
With the changes to scan the page cache for dirty data to avoid data
corruptions from partial write cleanup racing with other page cache
operations, the drop writes error injection no longer works the same
way it used to and causes xfs/196 to fail. This is because xfs/196
writes to the file and populates the page cache before it turns on
the error injection and starts failing -overwrites-.
The result is that the original drop-writes code failed writes only
-after- overwriting the data in the cache, followed by invalidates
the cached data, then punching out the delalloc extent from under
that data.
On the surface, this looks fine. The problem is that page cache
invalidation *doesn't guarantee that it removes anything from the
page cache* and it doesn't change the dirty state of the folio. When
block size == page size and we do page aligned IO (as xfs/196 does)
everything happens to align perfectly and page cache invalidation
removes the single page folios that span the written data. Hence the
followup delalloc punch pass does not find cached data over that
range and it can punch the extent out.
IOWs, xfs/196 "works" for block size == page size with the new
code. I say "works", because it actually only works for the case
where IO is page aligned, and no data was read from disk before
writes occur. Because the moment we actually read data first, the
readahead code allocates multipage folios and suddenly the
invalidate code goes back to zeroing subfolio ranges without
changing dirty state.
Hence, with multipage folios in play, block size == page size is
functionally identical to block size < page size behaviour, and
drop-writes is manifestly broken w.r.t to this case. Invalidation of
a subfolio range doesn't result in the folio being removed from the
cache, just the range gets zeroed. Hence after we've sequentially
walked over a folio that we've dirtied (via write data) and then
invalidated, we end up with a dirty folio full of zeroed data.
And because the new code skips punching ranges that have dirty
folios covering them, we end up leaving the delalloc range intact
after failing all the writes. Hence failed writes now end up
writing zeroes to disk in the cases where invalidation zeroes folios
rather than removing them from cache.
This is a fundamental change of behaviour that is needed to avoid
the data corruption vectors that exist in the old write fail path,
and it renders the drop-writes injection non-functional and
unworkable as it stands.
As it is, I think the error injection is also now unnecessary, as
partial writes that need delalloc extent are going to be a lot more
common with stale iomap detection in place. Hence this patch removes
the drop-writes error injection completely. xfs/196 can remain for
testing kernels that don't have this data corruption fix, but those
that do will report:
xfs/196 3s ... [not run] XFS error injection drop_writes unknown on this kernel.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
2022-11-28 22:09:17 +00:00
|
|
|
|
2017-10-31 19:04:49 +00:00
|
|
|
/*
|
xfs: drop write error injection is unfixable, remove it
With the changes to scan the page cache for dirty data to avoid data
corruptions from partial write cleanup racing with other page cache
operations, the drop writes error injection no longer works the same
way it used to and causes xfs/196 to fail. This is because xfs/196
writes to the file and populates the page cache before it turns on
the error injection and starts failing -overwrites-.
The result is that the original drop-writes code failed writes only
-after- overwriting the data in the cache, followed by invalidates
the cached data, then punching out the delalloc extent from under
that data.
On the surface, this looks fine. The problem is that page cache
invalidation *doesn't guarantee that it removes anything from the
page cache* and it doesn't change the dirty state of the folio. When
block size == page size and we do page aligned IO (as xfs/196 does)
everything happens to align perfectly and page cache invalidation
removes the single page folios that span the written data. Hence the
followup delalloc punch pass does not find cached data over that
range and it can punch the extent out.
IOWs, xfs/196 "works" for block size == page size with the new
code. I say "works", because it actually only works for the case
where IO is page aligned, and no data was read from disk before
writes occur. Because the moment we actually read data first, the
readahead code allocates multipage folios and suddenly the
invalidate code goes back to zeroing subfolio ranges without
changing dirty state.
Hence, with multipage folios in play, block size == page size is
functionally identical to block size < page size behaviour, and
drop-writes is manifestly broken w.r.t to this case. Invalidation of
a subfolio range doesn't result in the folio being removed from the
cache, just the range gets zeroed. Hence after we've sequentially
walked over a folio that we've dirtied (via write data) and then
invalidated, we end up with a dirty folio full of zeroed data.
And because the new code skips punching ranges that have dirty
folios covering them, we end up leaving the delalloc range intact
after failing all the writes. Hence failed writes now end up
writing zeroes to disk in the cases where invalidation zeroes folios
rather than removing them from cache.
This is a fundamental change of behaviour that is needed to avoid
the data corruption vectors that exist in the old write fail path,
and it renders the drop-writes injection non-functional and
unworkable as it stands.
As it is, I think the error injection is also now unnecessary, as
partial writes that need delalloc extent are going to be a lot more
common with stale iomap detection in place. Hence this patch removes
the drop-writes error injection completely. xfs/196 can remain for
testing kernels that don't have this data corruption fix, but those
that do will report:
xfs/196 3s ... [not run] XFS error injection drop_writes unknown on this kernel.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
2022-11-28 22:09:17 +00:00
|
|
|
* Drop-writes support removed because write error handling cannot trash
|
|
|
|
|
* pre-existing delalloc extents in any useful way anymore. We retain the
|
|
|
|
|
* definition so that we can reject it as an invalid value in
|
|
|
|
|
* xfs_errortag_valid().
|
2017-10-31 19:04:49 +00:00
|
|
|
*/
|
|
|
|
|
#define XFS_ERRTAG_DROP_WRITES 28
|
|
|
|
|
#define XFS_ERRTAG_LOG_BAD_CRC 29
|
|
|
|
|
#define XFS_ERRTAG_LOG_ITEM_PIN 30
|
|
|
|
|
#define XFS_ERRTAG_BUF_LRU_REF 31
|
2018-05-14 13:34:36 +00:00
|
|
|
#define XFS_ERRTAG_FORCE_SCRUB_REPAIR 32
|
2018-07-20 16:28:40 +00:00
|
|
|
#define XFS_ERRTAG_FORCE_SUMMARY_RECALC 33
|
2019-02-07 18:37:16 +00:00
|
|
|
#define XFS_ERRTAG_IUNLINK_FALLBACK 34
|
2020-05-06 20:29:19 +00:00
|
|
|
#define XFS_ERRTAG_BUF_IOERROR 35
|
2021-01-23 00:48:15 +00:00
|
|
|
#define XFS_ERRTAG_REDUCE_MAX_IEXTENTS 36
|
2021-01-23 00:48:17 +00:00
|
|
|
#define XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT 37
|
2021-03-24 02:05:39 +00:00
|
|
|
#define XFS_ERRTAG_AG_RESV_FAIL 38
|
2022-05-11 07:01:22 +00:00
|
|
|
#define XFS_ERRTAG_LARP 39
|
2022-05-11 07:01:23 +00:00
|
|
|
#define XFS_ERRTAG_DA_LEAF_SPLIT 40
|
2022-05-11 07:01:23 +00:00
|
|
|
#define XFS_ERRTAG_ATTR_LEAF_TO_NODE 41
|
2022-11-29 01:24:35 +00:00
|
|
|
#define XFS_ERRTAG_WB_DELAY_MS 42
|
2022-11-29 01:24:36 +00:00
|
|
|
#define XFS_ERRTAG_WRITE_DELAY_MS 43
|
|
|
|
|
#define XFS_ERRTAG_MAX 44
|
2017-10-31 19:04:49 +00:00
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
|
|
|
|
|
*/
|
|
|
|
|
#define XFS_RANDOM_DEFAULT 100
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_1 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_2 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_3 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_4 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_5 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IFLUSH_6 XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_DA_READ_BUF XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_BTREE_CHECK_LBLOCK (XFS_RANDOM_DEFAULT/4)
|
|
|
|
|
#define XFS_RANDOM_BTREE_CHECK_SBLOCK XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_ALLOC_READ_AGF XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IALLOC_READ_AGI XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_ITOBP_INOTOBP XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IUNLINK XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IUNLINK_REMOVE XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_DIR_INO_VALIDATE XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_BULKSTAT_READ_CHUNK XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_IODONE_IOERR (XFS_RANDOM_DEFAULT/10)
|
|
|
|
|
#define XFS_RANDOM_STRATREAD_IOERR (XFS_RANDOM_DEFAULT/10)
|
|
|
|
|
#define XFS_RANDOM_STRATCMPL_IOERR (XFS_RANDOM_DEFAULT/10)
|
|
|
|
|
#define XFS_RANDOM_DIOWRITE_IOERR (XFS_RANDOM_DEFAULT/10)
|
|
|
|
|
#define XFS_RANDOM_BMAPIFORMAT XFS_RANDOM_DEFAULT
|
|
|
|
|
#define XFS_RANDOM_FREE_EXTENT 1
|
|
|
|
|
#define XFS_RANDOM_RMAP_FINISH_ONE 1
|
|
|
|
|
#define XFS_RANDOM_REFCOUNT_CONTINUE_UPDATE 1
|
|
|
|
|
#define XFS_RANDOM_REFCOUNT_FINISH_ONE 1
|
|
|
|
|
#define XFS_RANDOM_BMAP_FINISH_ONE 1
|
|
|
|
|
#define XFS_RANDOM_AG_RESV_CRITICAL 4
|
|
|
|
|
#define XFS_RANDOM_LOG_BAD_CRC 1
|
|
|
|
|
#define XFS_RANDOM_LOG_ITEM_PIN 1
|
|
|
|
|
#define XFS_RANDOM_BUF_LRU_REF 2
|
2018-05-14 13:34:36 +00:00
|
|
|
#define XFS_RANDOM_FORCE_SCRUB_REPAIR 1
|
2018-07-20 16:28:40 +00:00
|
|
|
#define XFS_RANDOM_FORCE_SUMMARY_RECALC 1
|
2019-02-07 18:37:16 +00:00
|
|
|
#define XFS_RANDOM_IUNLINK_FALLBACK (XFS_RANDOM_DEFAULT/10)
|
2020-05-06 20:29:19 +00:00
|
|
|
#define XFS_RANDOM_BUF_IOERROR XFS_RANDOM_DEFAULT
|
2021-01-23 00:48:15 +00:00
|
|
|
#define XFS_RANDOM_REDUCE_MAX_IEXTENTS 1
|
2021-01-23 00:48:17 +00:00
|
|
|
#define XFS_RANDOM_BMAP_ALLOC_MINLEN_EXTENT 1
|
2021-03-24 02:05:39 +00:00
|
|
|
#define XFS_RANDOM_AG_RESV_FAIL 1
|
2022-05-11 07:01:22 +00:00
|
|
|
#define XFS_RANDOM_LARP 1
|
2022-05-11 07:01:23 +00:00
|
|
|
#define XFS_RANDOM_DA_LEAF_SPLIT 1
|
2022-05-11 07:01:23 +00:00
|
|
|
#define XFS_RANDOM_ATTR_LEAF_TO_NODE 1
|
2022-11-29 01:24:35 +00:00
|
|
|
#define XFS_RANDOM_WB_DELAY_MS 3000
|
2022-11-29 01:24:36 +00:00
|
|
|
#define XFS_RANDOM_WRITE_DELAY_MS 3000
|
2017-10-31 19:04:49 +00:00
|
|
|
|
|
|
|
|
#endif /* __XFS_ERRORTAG_H_ */
|