License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2008-10-23 05:26:29 +00:00
|
|
|
#ifndef _ASM_X86_SETUP_H
|
|
|
|
|
#define _ASM_X86_SETUP_H
|
2007-10-23 20:37:24 +00:00
|
|
|
|
2012-12-14 22:37:13 +00:00
|
|
|
#include <uapi/asm/setup.h>
|
|
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
#define COMMAND_LINE_SIZE 2048
|
|
|
|
|
|
2013-08-05 22:02:38 +00:00
|
|
|
#include <linux/linkage.h>
|
2016-04-26 19:23:24 +00:00
|
|
|
#include <asm/page_types.h>
|
2022-03-08 15:30:43 +00:00
|
|
|
#include <asm/ibt.h>
|
2013-08-05 22:02:38 +00:00
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
#ifdef __i386__
|
|
|
|
|
|
|
|
|
|
#include <linux/pfn.h>
|
|
|
|
|
/*
|
|
|
|
|
* Reserved space for vmalloc and iomap - defined in asm/page.h
|
|
|
|
|
*/
|
|
|
|
|
#define MAXMEM_PFN PFN_DOWN(MAXMEM)
|
|
|
|
|
#define MAX_NONPAE_PFN (1 << 20)
|
|
|
|
|
|
2007-10-23 20:37:25 +00:00
|
|
|
#endif /* __i386__ */
|
|
|
|
|
|
|
|
|
|
#define PARAM_SIZE 4096 /* sizeof(struct boot_params) */
|
2007-10-23 20:37:24 +00:00
|
|
|
|
|
|
|
|
#define OLD_CL_MAGIC 0xA33F
|
2007-10-23 20:37:25 +00:00
|
|
|
#define OLD_CL_ADDRESS 0x020 /* Relative to real mode data */
|
2007-10-23 20:37:24 +00:00
|
|
|
#define NEW_CL_POINTER 0x228 /* Relative to real mode data */
|
|
|
|
|
|
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
|
#include <asm/bootparam.h>
|
2009-08-19 13:37:03 +00:00
|
|
|
#include <asm/x86_init.h>
|
2007-10-23 20:37:24 +00:00
|
|
|
|
2009-02-02 16:29:19 +00:00
|
|
|
/* Interrupt control for vSMPowered x86_64 systems */
|
2009-03-24 06:14:29 +00:00
|
|
|
#ifdef CONFIG_X86_64
|
2009-02-02 16:29:19 +00:00
|
|
|
void vsmp_init(void);
|
2009-02-26 05:20:50 +00:00
|
|
|
#else
|
|
|
|
|
static inline void vsmp_init(void) { }
|
|
|
|
|
#endif
|
2009-02-02 16:29:19 +00:00
|
|
|
|
2020-09-07 13:15:36 +00:00
|
|
|
struct pt_regs;
|
|
|
|
|
|
2009-02-02 16:29:19 +00:00
|
|
|
void setup_bios_corruption_check(void);
|
2017-08-01 12:10:41 +00:00
|
|
|
void early_platform_quirks(void);
|
2009-02-02 16:29:19 +00:00
|
|
|
|
|
|
|
|
extern unsigned long saved_video_mode;
|
|
|
|
|
|
2009-08-19 12:55:50 +00:00
|
|
|
extern void reserve_standard_io_resources(void);
|
|
|
|
|
extern void i386_reserve_resources(void);
|
2018-12-04 23:34:56 +00:00
|
|
|
extern unsigned long __startup_64(unsigned long physaddr, struct boot_params *bp);
|
2020-09-07 13:15:30 +00:00
|
|
|
extern void startup_64_setup_env(unsigned long physbase);
|
2020-09-07 13:15:34 +00:00
|
|
|
extern void early_setup_idt(void);
|
2020-09-07 13:15:36 +00:00
|
|
|
extern void __init do_early_exception(struct pt_regs *regs, int trapnr);
|
2009-08-19 12:55:50 +00:00
|
|
|
|
2011-12-17 17:43:40 +00:00
|
|
|
#ifdef CONFIG_X86_INTEL_MID
|
2013-10-17 22:35:29 +00:00
|
|
|
extern void x86_intel_mid_early_setup(void);
|
2009-08-29 12:54:20 +00:00
|
|
|
#else
|
2013-10-17 22:35:29 +00:00
|
|
|
static inline void x86_intel_mid_early_setup(void) { }
|
2009-08-29 12:54:20 +00:00
|
|
|
#endif
|
|
|
|
|
|
2010-11-09 20:08:04 +00:00
|
|
|
#ifdef CONFIG_X86_INTEL_CE
|
|
|
|
|
extern void x86_ce4100_early_setup(void);
|
|
|
|
|
#else
|
|
|
|
|
static inline void x86_ce4100_early_setup(void) { }
|
|
|
|
|
#endif
|
|
|
|
|
|
2007-10-23 20:37:25 +00:00
|
|
|
#ifndef _SETUP
|
|
|
|
|
|
2014-05-01 21:12:23 +00:00
|
|
|
#include <asm/espfix.h>
|
2015-04-29 16:09:53 +00:00
|
|
|
#include <linux/kernel.h>
|
2014-05-01 21:12:23 +00:00
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
/*
|
|
|
|
|
* This is set up by the setup-routine at boot-time
|
|
|
|
|
*/
|
|
|
|
|
extern struct boot_params boot_params;
|
2015-04-27 11:17:19 +00:00
|
|
|
extern char _text[];
|
2007-10-23 20:37:24 +00:00
|
|
|
|
2015-04-01 10:49:52 +00:00
|
|
|
static inline bool kaslr_enabled(void)
|
|
|
|
|
{
|
2020-06-09 04:33:01 +00:00
|
|
|
return IS_ENABLED(CONFIG_RANDOMIZE_MEMORY) &&
|
|
|
|
|
!!(boot_params.hdr.loadflags & KASLR_FLAG);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Apply no randomization if KASLR was disabled at boot or if KASAN
|
|
|
|
|
* is enabled. KASAN shadow mappings rely on regions being PGD aligned.
|
|
|
|
|
*/
|
|
|
|
|
static inline bool kaslr_memory_enabled(void)
|
|
|
|
|
{
|
|
|
|
|
return kaslr_enabled() && !IS_ENABLED(CONFIG_KASAN);
|
2015-04-01 10:49:52 +00:00
|
|
|
}
|
|
|
|
|
|
2015-04-27 11:17:19 +00:00
|
|
|
static inline unsigned long kaslr_offset(void)
|
|
|
|
|
{
|
|
|
|
|
return (unsigned long)&_text - __START_KERNEL;
|
|
|
|
|
}
|
|
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
/*
|
|
|
|
|
* Do NOT EVER look at the BIOS memory size location.
|
|
|
|
|
* It does not work on many machines.
|
|
|
|
|
*/
|
|
|
|
|
#define LOWMEMSIZE() (0x9f000)
|
|
|
|
|
|
x86: add brk allocation for very, very early allocations
Impact: new interface
Add a brk()-like allocator which effectively extends the bss in order
to allow very early code to do dynamic allocations. This is better than
using statically allocated arrays for data in subsystems which may never
get used.
The space for brk allocations is in the bss ELF segment, so that the
space is mapped properly by the code which maps the kernel, and so
that bootloaders keep the space free rather than putting a ramdisk or
something into it.
The bss itself, delimited by __bss_stop, ends before the brk area
(__brk_base to __brk_limit). The kernel text, data and bss is reserved
up to __bss_stop.
Any brk-allocated data is reserved separately just before the kernel
pagetable is built, as that code allocates from unreserved spaces
in the e820 map, potentially allocating from any unused brk memory.
Ultimately any unused memory in the brk area is used in the general
kernel memory pool.
Initially the brk space is set to 1MB, which is probably much larger
than any user needs (the largest current user is i386 head_32.S's code
to build the pagetables to map the kernel, which can get fairly large
with a big kernel image and no PSE support). So long as the system
has sufficient memory for the bootloader to reserve the kernel+1MB brk,
there are no bad effects resulting from an over-large brk.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
2009-02-27 01:35:44 +00:00
|
|
|
/* exceedingly early brk-like allocator */
|
|
|
|
|
extern unsigned long _brk_end;
|
|
|
|
|
void *extend_brk(size_t size, size_t align);
|
|
|
|
|
|
2009-03-12 23:09:49 +00:00
|
|
|
/*
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
* Reserve space in the .brk section, which is a block of memory from which the
|
|
|
|
|
* caller is allowed to allocate very early (before even memblock is available)
|
|
|
|
|
* by calling extend_brk(). All allocated memory will be eventually converted
|
|
|
|
|
* to memblock. Any leftover unallocated memory will be freed.
|
2009-03-12 23:09:49 +00:00
|
|
|
*
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
* The size is in bytes.
|
2009-03-12 23:09:49 +00:00
|
|
|
*/
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
#define RESERVE_BRK(name, size) \
|
|
|
|
|
__section(".bss..brk") __aligned(1) __used \
|
|
|
|
|
static char __brk_##name[size]
|
2009-03-12 23:09:49 +00:00
|
|
|
|
2011-03-08 18:36:19 +00:00
|
|
|
extern void probe_roms(void);
|
2022-06-30 07:14:39 +00:00
|
|
|
|
|
|
|
|
void clear_bss(void);
|
|
|
|
|
|
2008-06-19 00:27:08 +00:00
|
|
|
#ifdef __i386__
|
|
|
|
|
|
2023-04-12 23:49:33 +00:00
|
|
|
asmlinkage void __init __noreturn i386_start_kernel(void);
|
2023-10-17 21:23:26 +00:00
|
|
|
void __init mk_early_pgtbl_32(void);
|
2008-01-30 12:31:11 +00:00
|
|
|
|
2008-06-25 04:19:09 +00:00
|
|
|
#else
|
2023-04-12 23:49:33 +00:00
|
|
|
asmlinkage void __init __noreturn x86_64_start_kernel(char *real_mode);
|
|
|
|
|
asmlinkage void __init __noreturn x86_64_start_reservations(char *real_mode_data);
|
2008-06-25 04:19:18 +00:00
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
#endif /* __i386__ */
|
2007-10-23 20:37:25 +00:00
|
|
|
#endif /* _SETUP */
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
|
|
|
|
|
#else /* __ASSEMBLY */
|
|
|
|
|
|
|
|
|
|
.macro __RESERVE_BRK name, size
|
|
|
|
|
.pushsection .bss..brk, "aw"
|
|
|
|
|
SYM_DATA_START(__brk_\name)
|
|
|
|
|
.skip \size
|
|
|
|
|
SYM_DATA_END(__brk_\name)
|
2009-03-12 23:09:49 +00:00
|
|
|
.popsection
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
.endm
|
|
|
|
|
|
|
|
|
|
#define RESERVE_BRK(name, size) __RESERVE_BRK name, size
|
|
|
|
|
|
2007-10-23 20:37:24 +00:00
|
|
|
#endif /* __ASSEMBLY__ */
|
x86/mm: Fix RESERVE_BRK() for older binutils
With binutils 2.26, RESERVE_BRK() causes a build failure:
/tmp/ccnGOKZ5.s: Assembler messages:
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: missing ')'
/tmp/ccnGOKZ5.s:98: Error: junk at end of line, first unrecognized
character is `U'
The problem is this line:
RESERVE_BRK(early_pgt_alloc, INIT_PGT_BUF_SIZE)
Specifically, the INIT_PGT_BUF_SIZE macro which (via PAGE_SIZE's use
_AC()) has a "1UL", which makes older versions of the assembler unhappy.
Unfortunately the _AC() macro doesn't work for inline asm.
Inline asm was only needed here to convince the toolchain to add the
STT_NOBITS flag. However, if a C variable is placed in a section whose
name is prefixed with ".bss", GCC and Clang automatically set
STT_NOBITS. In fact, ".bss..page_aligned" already relies on this trick.
So fix the build failure (and simplify the macro) by allocating the
variable in C.
Also, add NOLOAD to the ".brk" output section clause in the linker
script. This is a failsafe in case the ".bss" prefix magic trick ever
stops working somehow. If there's a section type mismatch, the GNU
linker will force the ".brk" output section to be STT_NOBITS. The LLVM
linker will fail with a "section type mismatch" error.
Note this also changes the name of the variable from .brk.##name to
__brk_##name. The variable names aren't actually used anywhere, so it's
harmless.
Fixes: a1e2c031ec39 ("x86/mm: Simplify RESERVE_BRK()")
Reported-by: Joe Damato <jdamato@fastly.com>
Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/22d07a44c80d8e8e1e82b9a806ddc8c6bbb2606e.1654759036.git.jpoimboe@kernel.org
2022-06-09 07:17:32 +00:00
|
|
|
|
2008-10-23 05:26:29 +00:00
|
|
|
#endif /* _ASM_X86_SETUP_H */
|