mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 06:33:07 +00:00
jffs2: free jffs2_sb_info through jffs2_kill_sb()
commit92e2921f7e
upstream. When an invalid mount option is passed to jffs2, jffs2_parse_options() will fail and jffs2_sb_info will be freed, but then jffs2_sb_info will be used (use-after-free) and freeed (double-free) in jffs2_kill_sb(). Fix it by removing the buggy invocation of kfree() when getting invalid mount options. Fixes:92abc475d8
("jffs2: implement mount option parsing and compression overriding") Cc: stable@kernel.org Signed-off-by: Hou Tao <houtao1@huawei.com> Reviewed-by: Richard Weinberger <richard@nod.at> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
0be4ef1290
commit
0035cb9d73
1 changed files with 1 additions and 3 deletions
|
@ -285,10 +285,8 @@ static int jffs2_fill_super(struct super_block *sb, void *data, int silent)
|
|||
sb->s_fs_info = c;
|
||||
|
||||
ret = jffs2_parse_options(c, data);
|
||||
if (ret) {
|
||||
kfree(c);
|
||||
if (ret)
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
/* Initialize JFFS2 superblock locks, the further initialization will
|
||||
* be done later */
|
||||
|
|
Loading…
Reference in a new issue