mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 23:58:05 +00:00
Code Issues Releases Wiki Activity

PCI Hotplug: cpqhp_pushbutton_thread(): remove a pointless if() check

Browse source 
The Coverity checker spotted that we'd have already oops'ed if "ctrl"
was NULL.

Additionally, "func" had just been checked for not being NULL.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Adrian Bunk 2007-10-24 18:25:00 +02:00 committed by Greg Kroah-Hartman
parent d73460d79b
commit 0039541088
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/pci/hotplug/cpqphp_ctrl.c
View file

@ -1931,16 +1931,14 @@ void cpqhp_pushbutton_thread(unsigned long slot)
return ; return ;
} }
if (func != NULL && ctrl != NULL) { if (cpqhp_process_SS(ctrl, func) != 0) {
if (cpqhp_process_SS(ctrl, func) != 0) { amber_LED_on(ctrl, hp_slot);
amber_LED_on (ctrl, hp_slot); green_LED_on(ctrl, hp_slot);
green_LED_on (ctrl, hp_slot);
set_SOGO(ctrl);
/* Wait for SOBS to be unset */ set_SOGO(ctrl);
wait_for_ctrl_irq (ctrl);
} /* Wait for SOBS to be unset */
wait_for_ctrl_irq(ctrl);
} }
p_slot->state = STATIC_STATE; p_slot->state = STATIC_STATE;