mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-06 10:57:46 +00:00
Code Issues Releases Wiki Activity

b43: reinit on too many PHY TX errors

Browse source 
Restart the hardware on too many PHY TX errors. A thousand PHY TX errors
per 15 seconds means we won't be able to recover for sure.

Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Stefano Brivio 2007-11-25 11:10:33 +01:00 committed by David S. Miller
parent d8be11ee95
commit 00e0b8cb74
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/wireless/b43/b43.h
View file

@ -393,6 +393,8 @@ enum {
#define B43_DEFAULT_SHORT_RETRY_LIMIT 7 #define B43_DEFAULT_SHORT_RETRY_LIMIT 7
#define B43_DEFAULT_LONG_RETRY_LIMIT 4 #define B43_DEFAULT_LONG_RETRY_LIMIT 4
#define B43_PHY_TX_BADNESS_LIMIT 1000
/* Max size of a security key */ /* Max size of a security key */
#define B43_SEC_KEYSIZE 16 #define B43_SEC_KEYSIZE 16
/* Security algorithms. */ /* Security algorithms. */
@ -548,6 +550,9 @@ struct b43_phy {
/* OFDM address read/write caching for hardware auto-increment. */ /* OFDM address read/write caching for hardware auto-increment. */
u16 ofdm_addr; u16 ofdm_addr;
u8 ofdm_valid; /* 0: invalid, 1: read, 2: write */ u8 ofdm_valid; /* 0: invalid, 1: read, 2: write */
/* PHY TX errors counter. */
atomic_t txerr_cnt;
}; };
/* Data structures for DMA transmission, per 80211 core. */ /* Data structures for DMA transmission, per 80211 core. */

17
drivers/net/wireless/b43/main.c
View file

@ -1394,8 +1394,17 @@ static void b43_interrupt_tasklet(struct b43_wldev *dev)
if (unlikely(reason & B43_IRQ_MAC_TXERR)) if (unlikely(reason & B43_IRQ_MAC_TXERR))
b43err(dev->wl, "MAC transmission error\n"); b43err(dev->wl, "MAC transmission error\n");
if (unlikely(reason & B43_IRQ_PHY_TXERR)) if (unlikely(reason & B43_IRQ_PHY_TXERR)) {
b43err(dev->wl, "PHY transmission error\n"); b43err(dev->wl, "PHY transmission error\n");
rmb();
if (unlikely(atomic_dec_and_test(&dev->phy.txerr_cnt))) {
atomic_set(&dev->phy.txerr_cnt,
B43_PHY_TX_BADNESS_LIMIT);
b43err(dev->wl, "Too many PHY TX errors, "
"restarting the controller\n");
b43_controller_restart(dev, "PHY TX errors");
}
}
if (unlikely(merged_dma_reason & (B43_DMAIRQ_FATALMASK | if (unlikely(merged_dma_reason & (B43_DMAIRQ_FATALMASK |
B43_DMAIRQ_NONFATALMASK))) { B43_DMAIRQ_NONFATALMASK))) {
@ -2257,6 +2266,9 @@ static int b43_chip_init(struct b43_wldev *dev)
/* OFDM address caching. */ /* OFDM address caching. */
phy->ofdm_valid = 0; phy->ofdm_valid = 0;
/* PHY TX errors counter. */
atomic_set(&phy->txerr_cnt, B43_PHY_TX_BADNESS_LIMIT);
err = 0; err = 0;
b43dbg(dev->wl, "Chip initialized\n"); b43dbg(dev->wl, "Chip initialized\n");
out: out:
@ -2341,6 +2353,9 @@ static void b43_periodic_every15sec(struct b43_wldev *dev)
} }
b43_phy_xmitpower(dev); //FIXME: unless scanning? b43_phy_xmitpower(dev); //FIXME: unless scanning?
//TODO for APHY (temperature?) //TODO for APHY (temperature?)
atomic_set(&phy->txerr_cnt, B43_PHY_TX_BADNESS_LIMIT);
wmb();
} }
static void do_periodic_work(struct b43_wldev *dev) static void do_periodic_work(struct b43_wldev *dev)