mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
pinctrl: amd: Add fields for interrupt status and wake status
If the firmware has misconfigured a GPIO it may cause interrupt status or wake status bits to be set and not asserted. Add these to debug output to catch this case. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/20230328174231.8924-3-mario.limonciello@amd.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
75358cf331
commit
010f493d90
1 changed files with 17 additions and 3 deletions
|
@ -211,6 +211,8 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
|
||||||
char *wake_cntrl1;
|
char *wake_cntrl1;
|
||||||
char *wake_cntrl2;
|
char *wake_cntrl2;
|
||||||
char *pin_sts;
|
char *pin_sts;
|
||||||
|
char *interrupt_sts;
|
||||||
|
char *wake_sts;
|
||||||
char *pull_up_sel;
|
char *pull_up_sel;
|
||||||
char *orientation;
|
char *orientation;
|
||||||
char debounce_value[40];
|
char debounce_value[40];
|
||||||
|
@ -243,7 +245,7 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
seq_printf(s, "GPIO bank%d\n", bank);
|
seq_printf(s, "GPIO bank%d\n", bank);
|
||||||
seq_puts(s, "gpio\tint|active|trigger|S0i3| S3|S4/S5| Z|wake|pull| orient| debounce|reg\n");
|
seq_puts(s, "gpio\t int|active|trigger|S0i3| S3|S4/S5| Z|wake|pull| orient| debounce|reg\n");
|
||||||
for (; i < pin_num; i++) {
|
for (; i < pin_num; i++) {
|
||||||
seq_printf(s, "#%d\t", i);
|
seq_printf(s, "#%d\t", i);
|
||||||
raw_spin_lock_irqsave(&gpio_dev->lock, flags);
|
raw_spin_lock_irqsave(&gpio_dev->lock, flags);
|
||||||
|
@ -274,12 +276,18 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
|
||||||
else
|
else
|
||||||
interrupt_mask = "😷";
|
interrupt_mask = "😷";
|
||||||
|
|
||||||
seq_printf(s, "%s| %s| %s|",
|
if (pin_reg & BIT(INTERRUPT_STS_OFF))
|
||||||
|
interrupt_sts = "🔥";
|
||||||
|
else
|
||||||
|
interrupt_sts = " ";
|
||||||
|
|
||||||
|
seq_printf(s, "%s %s| %s| %s|",
|
||||||
|
interrupt_sts,
|
||||||
interrupt_mask,
|
interrupt_mask,
|
||||||
active_level,
|
active_level,
|
||||||
level_trig);
|
level_trig);
|
||||||
} else
|
} else
|
||||||
seq_puts(s, " ∅| | |");
|
seq_puts(s, " ∅| | |");
|
||||||
|
|
||||||
if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
|
if (pin_reg & BIT(WAKE_CNTRL_OFF_S0I3))
|
||||||
wake_cntrl0 = "⏰";
|
wake_cntrl0 = "⏰";
|
||||||
|
@ -305,6 +313,12 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc)
|
||||||
wake_cntrlz = " ";
|
wake_cntrlz = " ";
|
||||||
seq_printf(s, "%s|", wake_cntrlz);
|
seq_printf(s, "%s|", wake_cntrlz);
|
||||||
|
|
||||||
|
if (pin_reg & BIT(WAKE_STS_OFF))
|
||||||
|
wake_sts = "🔥";
|
||||||
|
else
|
||||||
|
wake_sts = " ";
|
||||||
|
seq_printf(s, " %s|", wake_sts);
|
||||||
|
|
||||||
if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
|
if (pin_reg & BIT(PULL_UP_ENABLE_OFF)) {
|
||||||
if (pin_reg & BIT(PULL_UP_SEL_OFF))
|
if (pin_reg & BIT(PULL_UP_SEL_OFF))
|
||||||
pull_up_sel = "8k";
|
pull_up_sel = "8k";
|
||||||
|
|
Loading…
Reference in a new issue