mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 15:47:36 +00:00
USB: serial: keyspan_pda: fix modem-status error handling
Fix broken modem-status error handling which could lead to bits of slab
data leaking to user space.
Fixes: 3b36a8fd67
("usb: fix uninitialized variable warning in keyspan_pda")
Cc: stable <stable@vger.kernel.org> # 2.6.27
Signed-off-by: Johan Hovold <johan@kernel.org>
This commit is contained in:
parent
367b160fe4
commit
01b3cdfca2
1 changed files with 3 additions and 1 deletions
|
@ -369,8 +369,10 @@ static int keyspan_pda_get_modem_info(struct usb_serial *serial,
|
||||||
3, /* get pins */
|
3, /* get pins */
|
||||||
USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_IN,
|
USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_IN,
|
||||||
0, 0, data, 1, 2000);
|
0, 0, data, 1, 2000);
|
||||||
if (rc >= 0)
|
if (rc == 1)
|
||||||
*value = *data;
|
*value = *data;
|
||||||
|
else if (rc >= 0)
|
||||||
|
rc = -EIO;
|
||||||
|
|
||||||
kfree(data);
|
kfree(data);
|
||||||
return rc;
|
return rc;
|
||||||
|
|
Loading…
Reference in a new issue