mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

mm/damon/core: copy struct-to-struct instead of field-to-field in damon_new_scheme() 

The function for new 'struct damos' creation, 'damon_new_scheme()', copies
each field of the struct one by one, though it could simply copied via
struct to struct.  This commit replaces the unnecessarily verbose
field-to-field copies with struct-to-struct copies to make code simple and
short.

Link: https://lkml.kernel.org/r/20220913174449.50645-4-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2022-09-13 17:44:30 +00:00 committed by Andrew Morton
parent 8193321ac9
commit 02f17037fc
1 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
mm/damon/core.c
View File

@ -272,22 +272,13 @@ struct damos *damon_new_scheme(struct damos_access_pattern *pattern,
scheme = kmalloc(sizeof(*scheme), GFP_KERNEL);
if (!scheme)
return NULL;
scheme->pattern.min_sz_region = pattern->min_sz_region;
scheme->pattern.max_sz_region = pattern->max_sz_region;
scheme->pattern.min_nr_accesses = pattern->min_nr_accesses;
scheme->pattern.max_nr_accesses = pattern->max_nr_accesses;
scheme->pattern.min_age_region = pattern->min_age_region;
scheme->pattern.max_age_region = pattern->max_age_region;
scheme->pattern = *pattern;
scheme->action = action;
scheme->stat = (struct damos_stat){};
INIT_LIST_HEAD(&scheme->list);
scheme->quota.ms = quota->ms;
scheme->quota.sz = quota->sz;
scheme->quota.reset_interval = quota->reset_interval;
scheme->quota.weight_sz = quota->weight_sz;
scheme->quota.weight_nr_accesses = quota->weight_nr_accesses;
scheme->quota.weight_age = quota->weight_age;
scheme->quota = *quota;
/* caller might not zero-initialized the private fileds */
scheme->quota.total_charged_sz = 0;
scheme->quota.total_charged_ns = 0;
scheme->quota.esz = 0;
@ -296,11 +287,7 @@ struct damos *damon_new_scheme(struct damos_access_pattern *pattern,
scheme->quota.charge_target_from = NULL;
scheme->quota.charge_addr_from = 0;
scheme->wmarks.metric = wmarks->metric;
scheme->wmarks.interval = wmarks->interval;
scheme->wmarks.high = wmarks->high;
scheme->wmarks.mid = wmarks->mid;
scheme->wmarks.low = wmarks->low;
scheme->wmarks = *wmarks;
scheme->wmarks.activated = true;
return scheme;