mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
lib82596: Fix IRQ check in sni_82596_probe
commit99218cbf81
upstream. platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes:1159788592
("i825xx: Move the Intel 82586/82593/82596 based drivers") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
1a30f9c76b
commit
04d1dbd1e8
1 changed files with 2 additions and 1 deletions
|
@ -122,9 +122,10 @@ static int sni_82596_probe(struct platform_device *dev)
|
||||||
netdevice->dev_addr[5] = readb(eth_addr + 0x06);
|
netdevice->dev_addr[5] = readb(eth_addr + 0x06);
|
||||||
iounmap(eth_addr);
|
iounmap(eth_addr);
|
||||||
|
|
||||||
if (!netdevice->irq) {
|
if (netdevice->irq < 0) {
|
||||||
printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
|
printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
|
||||||
__FILE__, netdevice->base_addr);
|
__FILE__, netdevice->base_addr);
|
||||||
|
retval = netdevice->irq;
|
||||||
goto probe_failed;
|
goto probe_failed;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue