mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 19:07:52 +00:00
x86/amd-iommu: Pt mode fix for domain_destroy
After a guest is shutdown, assigned devices are not properly returned to the pt domain. This can leave the device using stale cached IOMMU data, and result in a non-functional device after it's re-bound to the host driver. For example, I see this upon rebinding: AMD-Vi: Event logged [IO_PAGE_FAULT device=02:00.0 domain=0x0000 address=0x000000007e2a8000 flags=0x0050] AMD-Vi: Event logged [IO_PAGE_FAULT device=02:00.0 domain=0x0000 address=0x000000007e2a8040 flags=0x0050] AMD-Vi: Event logged [IO_PAGE_FAULT device=02:00.0 domain=0x0000 address=0x000000007e2a8080 flags=0x0050] AMD-Vi: Event logged [IO_PAGE_FAULT device=02:00.0 domain=0x0000 address=0x000000007e2a80c0 flags=0x0050] 0000:02:00.0: eth2: Detected Hardware Unit Hang: ... The amd_iommu_destroy_domain() function calls do_detach() which doesn't reattach the pt domain to the device. Use __detach_device() instead. Cc: stable@kernel.org Signed-off-by: Chris Wright <chrisw@sous-sol.org> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
This commit is contained in:
parent
5d214fe6e8
commit
04e856c072
1 changed files with 1 additions and 1 deletions
|
@ -2298,7 +2298,7 @@ static void cleanup_domain(struct protection_domain *domain)
|
||||||
list_for_each_entry_safe(dev_data, next, &domain->dev_list, list) {
|
list_for_each_entry_safe(dev_data, next, &domain->dev_list, list) {
|
||||||
struct device *dev = dev_data->dev;
|
struct device *dev = dev_data->dev;
|
||||||
|
|
||||||
do_detach(dev);
|
__detach_device(dev);
|
||||||
atomic_set(&dev_data->bind, 0);
|
atomic_set(&dev_data->bind, 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue