mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 23:27:06 +00:00
staging: vchiq_2835_arm: Make cache-line-size a required DT property
[ Upstream commit 6cf1bf636a
]
The original github source allowed for the cache-line-size property
to be missing. Since recent firmwares also require this property,
it makes sense to always require it in the driver as well.
If the cache-line-size property is missing, then the driver probe
should fail as no dev since the kernel and dt may be out of sync.
The fix is to add a check for the return value of of_property_read_u32.
Changes V2:
1. Add error message if cache-line-size is missing.
2. Simple check for non-zero return value from
of_property_read_u32.
Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
b1b73cc046
commit
0500fcd885
1 changed files with 7 additions and 1 deletions
|
@ -106,8 +106,14 @@ int vchiq_platform_init(struct platform_device *pdev, VCHIQ_STATE_T *state)
|
|||
|
||||
g_virt_to_bus_offset = virt_to_dma(dev, (void *)0);
|
||||
|
||||
(void)of_property_read_u32(dev->of_node, "cache-line-size",
|
||||
err = of_property_read_u32(dev->of_node, "cache-line-size",
|
||||
&g_cache_line_size);
|
||||
|
||||
if (err) {
|
||||
dev_err(dev, "Missing cache-line-size property\n");
|
||||
return -ENODEV;
|
||||
}
|
||||
|
||||
g_fragments_size = 2 * g_cache_line_size;
|
||||
|
||||
/* Allocate space for the channels in coherent memory */
|
||||
|
|
Loading…
Reference in a new issue