mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 18:30:06 +00:00
drm/panel: ltk050h3146w: use dev_err_probe wherever possible
This is only a cosmetic change. This replaces a hand-crafted EPROBE_DEFER handling for deciding to print an error message with dev_err_probe. A side-effect is that dev_err_probe also adds a debug message when it's not EPROBE_DEFER, but this is seen as an improvement. Cc: Quentin Schulz <foss+kernel@0leil.net> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Link: https://patchwork.freedesktop.org/patch/msgid/20240104-ltk-dev_err_probe-v1-2-8ef3c0b585d8@theobroma-systems.com
This commit is contained in:
parent
65afd91e8d
commit
056a9965e5
1 changed files with 5 additions and 12 deletions
|
@ -650,20 +650,13 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)
|
||||||
return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "cannot get reset gpio\n");
|
return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio), "cannot get reset gpio\n");
|
||||||
|
|
||||||
ctx->vci = devm_regulator_get(dev, "vci");
|
ctx->vci = devm_regulator_get(dev, "vci");
|
||||||
if (IS_ERR(ctx->vci)) {
|
if (IS_ERR(ctx->vci))
|
||||||
ret = PTR_ERR(ctx->vci);
|
return dev_err_probe(dev, PTR_ERR(ctx->vci), "Failed to request vci regulator\n");
|
||||||
if (ret != -EPROBE_DEFER)
|
|
||||||
dev_err(dev, "Failed to request vci regulator: %d\n", ret);
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx->iovcc = devm_regulator_get(dev, "iovcc");
|
ctx->iovcc = devm_regulator_get(dev, "iovcc");
|
||||||
if (IS_ERR(ctx->iovcc)) {
|
if (IS_ERR(ctx->iovcc))
|
||||||
ret = PTR_ERR(ctx->iovcc);
|
return dev_err_probe(dev, PTR_ERR(ctx->iovcc),
|
||||||
if (ret != -EPROBE_DEFER)
|
"Failed to request iovcc regulator\n");
|
||||||
dev_err(dev, "Failed to request iovcc regulator: %d\n", ret);
|
|
||||||
return ret;
|
|
||||||
}
|
|
||||||
|
|
||||||
mipi_dsi_set_drvdata(dsi, ctx);
|
mipi_dsi_set_drvdata(dsi, ctx);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue