mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
qmi_wwan: Do not call netif_rx from rx_fixup
When the QMI_WWAN_FLAG_PASS_THROUGH is set, netif_rx() is called from qmi_wwan_rx_fixup(). When the call to netif_rx() is successful (which is most of the time), usbnet_skb_return() is called (from rx_process()). usbnet_skb_return() will then call netif_rx() a second time for the same skb. Simplify the code and avoid the redundant netif_rx() call by changing qmi_wwan_rx_fixup() to always return 1 when QMI_WWAN_FLAG_PASS_THROUGH is set. We then leave it up to the existing infrastructure to call netif_rx(). Suggested-by: Bjørn Mork <bjorn@mork.no> Signed-off-by: Kristian Evensen <kristian.evensen@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
c1a3d40673
commit
057d49334c
1 changed files with 1 additions and 1 deletions
|
@ -575,7 +575,7 @@ static int qmi_wwan_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
|
||||||
|
|
||||||
if (info->flags & QMI_WWAN_FLAG_PASS_THROUGH) {
|
if (info->flags & QMI_WWAN_FLAG_PASS_THROUGH) {
|
||||||
skb->protocol = htons(ETH_P_MAP);
|
skb->protocol = htons(ETH_P_MAP);
|
||||||
return (netif_rx(skb) == NET_RX_SUCCESS);
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
switch (skb->data[0] & 0xf0) {
|
switch (skb->data[0] & 0xf0) {
|
||||||
|
|
Loading…
Reference in a new issue