mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-20 14:16:02 +00:00
[PATCH] libata: always generate sense if qc->err_mask is non-zero
Current sense generation code does not generate sense error if status register value doesn't indicate error condition. However, LLDD's may indicate errors which 't show up in status register. Completing such qc's without generating sense results in successful completion of failed commands. Invoke ata_to_sense_error() regardless of status register if qc->err_mask is not zero such that ata_to_sense_error() generates default sense error. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
parent
c91af2c87e
commit
058e55e120
1 changed files with 4 additions and 2 deletions
|
@ -555,7 +555,8 @@ void ata_gen_ata_desc_sense(struct ata_queued_cmd *qc)
|
||||||
* Use ata_to_sense_error() to map status register bits
|
* Use ata_to_sense_error() to map status register bits
|
||||||
* onto sense key, asc & ascq.
|
* onto sense key, asc & ascq.
|
||||||
*/
|
*/
|
||||||
if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
|
if (qc->err_mask ||
|
||||||
|
tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
|
||||||
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
|
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
|
||||||
&sb[1], &sb[2], &sb[3]);
|
&sb[1], &sb[2], &sb[3]);
|
||||||
sb[1] &= 0x0f;
|
sb[1] &= 0x0f;
|
||||||
|
@ -630,7 +631,8 @@ void ata_gen_fixed_sense(struct ata_queued_cmd *qc)
|
||||||
* Use ata_to_sense_error() to map status register bits
|
* Use ata_to_sense_error() to map status register bits
|
||||||
* onto sense key, asc & ascq.
|
* onto sense key, asc & ascq.
|
||||||
*/
|
*/
|
||||||
if (tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
|
if (qc->err_mask ||
|
||||||
|
tf->command & (ATA_BUSY | ATA_DF | ATA_ERR | ATA_DRQ)) {
|
||||||
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
|
ata_to_sense_error(qc->ap->id, tf->command, tf->feature,
|
||||||
&sb[2], &sb[12], &sb[13]);
|
&sb[2], &sb[12], &sb[13]);
|
||||||
sb[2] &= 0x0f;
|
sb[2] &= 0x0f;
|
||||||
|
|
Loading…
Reference in a new issue