mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 16:37:50 +00:00
power: supply: tps65217_charger: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230918133700.1254499-27-u.kleine-koenig@pengutronix.de Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
This commit is contained in:
parent
75d8365c94
commit
07a9398914
1 changed files with 2 additions and 4 deletions
|
@ -253,14 +253,12 @@ static int tps65217_charger_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int tps65217_charger_remove(struct platform_device *pdev)
|
||||
static void tps65217_charger_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct tps65217_charger *charger = platform_get_drvdata(pdev);
|
||||
|
||||
if (charger->poll_task)
|
||||
kthread_stop(charger->poll_task);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id tps65217_charger_match_table[] = {
|
||||
|
@ -271,7 +269,7 @@ MODULE_DEVICE_TABLE(of, tps65217_charger_match_table);
|
|||
|
||||
static struct platform_driver tps65217_charger_driver = {
|
||||
.probe = tps65217_charger_probe,
|
||||
.remove = tps65217_charger_remove,
|
||||
.remove_new = tps65217_charger_remove,
|
||||
.driver = {
|
||||
.name = "tps65217-charger",
|
||||
.of_match_table = of_match_ptr(tps65217_charger_match_table),
|
||||
|
|
Loading…
Reference in a new issue