mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
qede: Fix out-of-bound fastpath memory access
Driver allocates a shadow array for transmitted SKBs with X entries; That means valid indices are {0,...,X - 1}. [X == 8191] Problem is the driver also uses X as a mask for a producer/consumer in order to choose the right entry in the array which allows access to entry X which is out of bounds. To fix this, simply allocate X + 1 entries in the shadow array. Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3034783472
commit
087892d29b
1 changed files with 2 additions and 2 deletions
|
@ -2940,7 +2940,7 @@ static int qede_alloc_mem_txq(struct qede_dev *edev, struct qede_tx_queue *txq)
|
|||
txq->num_tx_buffers = edev->q_num_tx_buffers;
|
||||
|
||||
/* Allocate the parallel driver ring for Tx buffers */
|
||||
size = sizeof(*txq->sw_tx_ring) * NUM_TX_BDS_MAX;
|
||||
size = sizeof(*txq->sw_tx_ring) * TX_RING_SIZE;
|
||||
txq->sw_tx_ring = kzalloc(size, GFP_KERNEL);
|
||||
if (!txq->sw_tx_ring) {
|
||||
DP_NOTICE(edev, "Tx buffers ring allocation failed\n");
|
||||
|
@ -2951,7 +2951,7 @@ static int qede_alloc_mem_txq(struct qede_dev *edev, struct qede_tx_queue *txq)
|
|||
QED_CHAIN_USE_TO_CONSUME_PRODUCE,
|
||||
QED_CHAIN_MODE_PBL,
|
||||
QED_CHAIN_CNT_TYPE_U16,
|
||||
NUM_TX_BDS_MAX,
|
||||
TX_RING_SIZE,
|
||||
sizeof(*p_virt), &txq->tx_pbl);
|
||||
if (rc)
|
||||
goto err;
|
||||
|
|
Loading…
Reference in a new issue