mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-21 00:10:09 +00:00
Code Issues Releases Wiki Activity

[PATCH] FPU context corrupted after resume

Browse source 
mxcsr_feature_mask_init isn't needed in suspend/resume time (we can use
boot time mask).  And actually it's harmful, as it clear task's saved
fxsave in resume.  This bug is widely seen by users using zsh.

(akpm: my eyes.  Fixed some surrounding whitespace mess)

Signed-off-by: Shaohua Li<shaohua.li@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Andi Kleen <ak@muc.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Shaohua Li 2005-10-30 14:59:28 -08:00 committed by Linus Torvalds
parent 8896fab35e
commit 08967f941a
2 changed files with 10 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
arch/i386/power/cpu.c
View file

@ -51,16 +51,14 @@ void save_processor_state(void)
__save_processor_state(&saved_context); __save_processor_state(&saved_context);
} }
static void static void do_fpu_end(void)
do_fpu_end(void)
{ {
/* restore FPU regs if necessary */ /*
/* Do it out of line so that gcc does not move cr0 load to some stupid place */ * Restore FPU regs if necessary.
kernel_fpu_end(); */
mxcsr_feature_mask_init(); kernel_fpu_end();
} }
static void fix_processor_context(void) static void fix_processor_context(void)
{ {
int cpu = smp_processor_id(); int cpu = smp_processor_id();

11
arch/x86_64/kernel/suspend.c
View file

@ -63,13 +63,12 @@ void save_processor_state(void)
__save_processor_state(&saved_context); __save_processor_state(&saved_context);
} }
static void static void do_fpu_end(void)
do_fpu_end(void)
{ {
/* restore FPU regs if necessary */ /*
/* Do it out of line so that gcc does not move cr0 load to some stupid place */ * Restore FPU regs if necessary
kernel_fpu_end(); */
mxcsr_feature_mask_init(); kernel_fpu_end();
} }
void __restore_processor_state(struct saved_context *ctxt) void __restore_processor_state(struct saved_context *ctxt)