mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
nfs: setattr can only change regular file sizes
The VFS never calls setattr with ATTR_SIZE on anything but regular files. Remove the if check and turn it into an assert similar to what some other file systems do. Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
This commit is contained in:
parent
20d655d619
commit
08a899d5d9
1 changed files with 3 additions and 1 deletions
|
@ -505,7 +505,9 @@ nfs_setattr(struct dentry *dentry, struct iattr *attr)
|
|||
attr->ia_valid &= ~ATTR_MODE;
|
||||
|
||||
if (attr->ia_valid & ATTR_SIZE) {
|
||||
if (!S_ISREG(inode->i_mode) || attr->ia_size == i_size_read(inode))
|
||||
BUG_ON(!S_ISREG(inode->i_mode));
|
||||
|
||||
if (attr->ia_size == i_size_read(inode))
|
||||
attr->ia_valid &= ~ATTR_SIZE;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue