mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-05 08:26:59 +00:00
Code Issues Releases Wiki Activity

media: rc: decoders do not need to check for transitions

Browse source 
Drivers should never produce consecutive pulse or space raw events. Should
that occur, we would have bigger problems than this code is trying to
guard against.

Note that we already log an error should a driver misbehave.

Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Sean Young 2018-05-10 06:14:38 -04:00 committed by Mauro Carvalho Chehab
parent 48231f289e
commit 09161a0552
3 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/media/rc/ir-mce_kbd-decoder.c
View file

@ -274,9 +274,6 @@ static int ir_mce_kbd_decode(struct rc_dev *dev, struct ir_raw_event ev)
return 0; return 0;
case STATE_HEADER_BIT_END: case STATE_HEADER_BIT_END:
if (!is_transition(&ev, &dev->raw->prev_ev))
break;
decrease_duration(&ev, MCIR2_BIT_END); decrease_duration(&ev, MCIR2_BIT_END);
if (data->count != MCIR2_HEADER_NBITS) { if (data->count != MCIR2_HEADER_NBITS) {
@ -313,9 +310,6 @@ static int ir_mce_kbd_decode(struct rc_dev *dev, struct ir_raw_event ev)
return 0; return 0;
case STATE_BODY_BIT_END: case STATE_BODY_BIT_END:
if (!is_transition(&ev, &dev->raw->prev_ev))
break;
if (data->count == data->wanted_bits) if (data->count == data->wanted_bits)
data->state = STATE_FINISHED; data->state = STATE_FINISHED;
else else

3
drivers/media/rc/ir-rc5-decoder.c
View file

@ -88,9 +88,6 @@ static int ir_rc5_decode(struct rc_dev *dev, struct ir_raw_event ev)
return 0; return 0;
case STATE_BIT_END: case STATE_BIT_END:
if (!is_transition(&ev, &dev->raw->prev_ev))
break;
if (data->count == CHECK_RC5X_NBITS) if (data->count == CHECK_RC5X_NBITS)
data->state = STATE_CHECK_RC5X; data->state = STATE_CHECK_RC5X;
else else

10
drivers/media/rc/ir-rc6-decoder.c
View file

@ -145,9 +145,6 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev)
return 0; return 0;
case STATE_HEADER_BIT_END: case STATE_HEADER_BIT_END:
if (!is_transition(&ev, &dev->raw->prev_ev))
break;
if (data->count == RC6_HEADER_NBITS) if (data->count == RC6_HEADER_NBITS)
data->state = STATE_TOGGLE_START; data->state = STATE_TOGGLE_START;
else else
@ -165,10 +162,6 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev)
return 0; return 0;
case STATE_TOGGLE_END: case STATE_TOGGLE_END:
if (!is_transition(&ev, &dev->raw->prev_ev) ||
!geq_margin(ev.duration, RC6_TOGGLE_END, RC6_UNIT / 2))
break;
if (!(data->header & RC6_STARTBIT_MASK)) { if (!(data->header & RC6_STARTBIT_MASK)) {
dev_dbg(&dev->dev, "RC6 invalid start bit\n"); dev_dbg(&dev->dev, "RC6 invalid start bit\n");
break; break;
@ -210,9 +203,6 @@ static int ir_rc6_decode(struct rc_dev *dev, struct ir_raw_event ev)
break; break;
case STATE_BODY_BIT_END: case STATE_BODY_BIT_END:
if (!is_transition(&ev, &dev->raw->prev_ev))
break;
if (data->count == data->wanted_bits) if (data->count == data->wanted_bits)
data->state = STATE_FINISHED; data->state = STATE_FINISHED;
else else