mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
hwrng: xgene - fix handling platform_get_irq
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
parent
17762c5ace
commit
09185e2756
1 changed files with 4 additions and 3 deletions
|
@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev)
|
||||||
if (IS_ERR(ctx->csr_base))
|
if (IS_ERR(ctx->csr_base))
|
||||||
return PTR_ERR(ctx->csr_base);
|
return PTR_ERR(ctx->csr_base);
|
||||||
|
|
||||||
ctx->irq = platform_get_irq(pdev, 0);
|
rc = platform_get_irq(pdev, 0);
|
||||||
if (ctx->irq < 0) {
|
if (rc < 0) {
|
||||||
dev_err(&pdev->dev, "No IRQ resource\n");
|
dev_err(&pdev->dev, "No IRQ resource\n");
|
||||||
return ctx->irq;
|
return rc;
|
||||||
}
|
}
|
||||||
|
ctx->irq = rc;
|
||||||
|
|
||||||
dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
|
dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",
|
||||||
ctx->csr_base, ctx->irq);
|
ctx->csr_base, ctx->irq);
|
||||||
|
|
Loading…
Reference in a new issue