mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 02:19:51 +00:00
gpiolib: Forbid irqchip default trigger for ACPI enumerated devices
Follow DT and forbid default trigger if the GPIO irqchip device is enumerated from ACPI. Triggering for these devices will be configured automatically from ACPI interrupt resources provided by the BIOS. Suggested-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
parent
e35b5ab0a7
commit
0a1e005374
1 changed files with 6 additions and 1 deletions
|
@ -1614,13 +1614,18 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip,
|
|||
of_node = gpiochip->of_node;
|
||||
#endif
|
||||
/*
|
||||
* Specifying a default trigger is a terrible idea if DT is
|
||||
* Specifying a default trigger is a terrible idea if DT or ACPI is
|
||||
* used to configure the interrupts, as you may end-up with
|
||||
* conflicting triggers. Tell the user, and reset to NONE.
|
||||
*/
|
||||
if (WARN(of_node && type != IRQ_TYPE_NONE,
|
||||
"%s: Ignoring %d default trigger\n", of_node->full_name, type))
|
||||
type = IRQ_TYPE_NONE;
|
||||
if (has_acpi_companion(gpiochip->parent) && type != IRQ_TYPE_NONE) {
|
||||
acpi_handle_warn(ACPI_HANDLE(gpiochip->parent),
|
||||
"Ignoring %d default trigger\n", type);
|
||||
type = IRQ_TYPE_NONE;
|
||||
}
|
||||
|
||||
gpiochip->irqchip = irqchip;
|
||||
gpiochip->irq_handler = handler;
|
||||
|
|
Loading…
Reference in a new issue