mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
i2c: fsi: Add of_put_node() before break
Each iteration of for_each_available_childe_of_node puts the previous node, but in the case of a break from the middle of the loop, there is no put, thus causing a memory leak. Add an of_node_put before the break. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com> Reviewed-by: Eddie James <eajames@linux.ibm.com> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
This commit is contained in:
parent
7077ad2ee3
commit
0a321b9736
1 changed files with 3 additions and 1 deletions
|
@ -707,8 +707,10 @@ static int fsi_i2c_probe(struct device *dev)
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
port = kzalloc(sizeof(*port), GFP_KERNEL);
|
port = kzalloc(sizeof(*port), GFP_KERNEL);
|
||||||
if (!port)
|
if (!port) {
|
||||||
|
of_node_put(np);
|
||||||
break;
|
break;
|
||||||
|
}
|
||||||
|
|
||||||
port->master = i2c;
|
port->master = i2c;
|
||||||
port->port = port_no;
|
port->port = port_no;
|
||||||
|
|
Loading…
Reference in a new issue