mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
media: em28xx: fix memory leak
If some error occurs, URB buffers should also be freed. If they aren't freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB buffers as dvb is set to NULL. The function in which error occurs should do all the cleanup for the allocations it had done. Tested the patch with the reproducer provided by syzbot. This patch fixes the memleak. Reported-by: syzbot+889397c820fa56adf25d@syzkaller.appspotmail.com Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
73c9a3f3b3
commit
0ae10a7dc8
1 changed files with 1 additions and 0 deletions
|
@ -2010,6 +2010,7 @@ static int em28xx_dvb_init(struct em28xx *dev)
|
|||
return result;
|
||||
|
||||
out_free:
|
||||
em28xx_uninit_usb_xfer(dev, EM28XX_DIGITAL_MODE);
|
||||
kfree(dvb);
|
||||
dev->dvb = NULL;
|
||||
goto ret;
|
||||
|
|
Loading…
Reference in a new issue