mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
be2net: do not remove vids from driver table if be_vid_config() fails.
The driver currently removes a new vid from the adapter->vids[] array if be_vid_config() returns an error, which occurs when there is an error in HW/FW. This is wrong. After the HW/FW error is recovered from, we need the complete vids[] array to re-program the vlan list. Signed-off-by: Sathya Perla <sathya.perla@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
841f60fcc4
commit
0aff1fbfe7
1 changed files with 1 additions and 7 deletions
|
@ -1463,13 +1463,7 @@ static int be_vlan_add_vid(struct net_device *netdev, __be16 proto, u16 vid)
|
|||
set_bit(vid, adapter->vids);
|
||||
adapter->vlans_added++;
|
||||
|
||||
status = be_vid_config(adapter);
|
||||
if (status) {
|
||||
adapter->vlans_added--;
|
||||
clear_bit(vid, adapter->vids);
|
||||
}
|
||||
|
||||
return status;
|
||||
return be_vid_config(adapter);
|
||||
}
|
||||
|
||||
static int be_vlan_rem_vid(struct net_device *netdev, __be16 proto, u16 vid)
|
||||
|
|
Loading…
Reference in a new issue