mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
sound/soc/mxs/mxs-saif.c: add missing kfree
Move the test on pdev->id before the kzalloc to avoid requiring kfree when the test fails. This fix was suggested by Wolfram Sang. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x; expression E1!=0,E2,E3,E4; statement S; iterator I; @@ ( if (...) { ... when != kfree(x) when != x = E3 when != E3 = x * return ...; } ... when != x = E2 when != I(...,x,...) S if (...) { ... when != x = E4 kfree(x); ... return ...; } ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Dong Aisheng <b29396@freescale.com> Reviewed-by: Wolfram Sang <w.sang@pengutronix.de> Acked-by: Liam Girdwood <lrg@ti.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
parent
bbe8ff5e25
commit
0bb98ba2b0
1 changed files with 3 additions and 2 deletions
|
@ -521,12 +521,13 @@ static int mxs_saif_probe(struct platform_device *pdev)
|
|||
struct mxs_saif *saif;
|
||||
int ret = 0;
|
||||
|
||||
if (pdev->id >= ARRAY_SIZE(mxs_saif))
|
||||
return -EINVAL;
|
||||
|
||||
saif = kzalloc(sizeof(*saif), GFP_KERNEL);
|
||||
if (!saif)
|
||||
return -ENOMEM;
|
||||
|
||||
if (pdev->id >= ARRAY_SIZE(mxs_saif))
|
||||
return -EINVAL;
|
||||
mxs_saif[pdev->id] = saif;
|
||||
|
||||
saif->clk = clk_get(&pdev->dev, NULL);
|
||||
|
|
Loading…
Reference in a new issue