mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-19 09:04:57 +00:00
media: venus: core: Fix a resource leak in the error handling path of 'venus_probe()'
[ Upstream commit8cc7a1b2ac
] A successful 'of_platform_populate()' call should be balanced by a corresponding 'of_platform_depopulate()' call in the error handling path of the probe, as already done in the remove function. A successful 'venus_firmware_init()' call should be balanced by a corresponding 'venus_firmware_deinit()' call in the error handling path of the probe, as already done in the remove function. Update the error handling path accordingly. Fixes:f9799fcce4
("media: venus: firmware: register separate platform_device for firmware loader") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
4a8a8ff652
commit
0bc65fcb2b
1 changed files with 6 additions and 2 deletions
|
@ -349,11 +349,11 @@ static int venus_probe(struct platform_device *pdev)
|
|||
|
||||
ret = venus_firmware_init(core);
|
||||
if (ret)
|
||||
goto err_runtime_disable;
|
||||
goto err_of_depopulate;
|
||||
|
||||
ret = venus_boot(core);
|
||||
if (ret)
|
||||
goto err_runtime_disable;
|
||||
goto err_firmware_deinit;
|
||||
|
||||
ret = hfi_core_resume(core, true);
|
||||
if (ret)
|
||||
|
@ -385,6 +385,10 @@ static int venus_probe(struct platform_device *pdev)
|
|||
v4l2_device_unregister(&core->v4l2_dev);
|
||||
err_venus_shutdown:
|
||||
venus_shutdown(core);
|
||||
err_firmware_deinit:
|
||||
venus_firmware_deinit(core);
|
||||
err_of_depopulate:
|
||||
of_platform_depopulate(dev);
|
||||
err_runtime_disable:
|
||||
pm_runtime_put_noidle(dev);
|
||||
pm_runtime_set_suspended(dev);
|
||||
|
|
Loading…
Reference in a new issue