mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 03:10:12 +00:00
module: Remove const attribute from alias for MODULE_DEVICE_TABLE
MODULE_DEVICE_TABLE(type, name) creates an alias of type 'extern const typeof(name)'. If 'name' is already constant the 'const' attribute is specified twice, which is not allowed in C89 (see discussion at https://lkml.org/lkml/2017/5/23/1440). Since the kernel is built with -std=gnu89 clang generates warnings like this: drivers/thermal/x86_pkg_temp_thermal.c:509:1: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier] MODULE_DEVICE_TABLE(x86cpu, pkg_temp_thermal_ids); ^ ./include/linux/module.h:212:8: note: expanded from macro 'MODULE_DEVICE_TABLE' extern const typeof(name) __mod_##type##__##name##_device_table Remove the const attribute from the alias to avoid the duplicate specifier. After all it is only an alias and the attribute shouldn't have any effect. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Signed-off-by: Jessica Yu <jeyu@kernel.org>
This commit is contained in:
parent
5279631271
commit
0bf8bf50ed
1 changed files with 1 additions and 1 deletions
|
@ -209,7 +209,7 @@ extern void cleanup_module(void);
|
||||||
#ifdef MODULE
|
#ifdef MODULE
|
||||||
/* Creates an alias so file2alias.c can find device table. */
|
/* Creates an alias so file2alias.c can find device table. */
|
||||||
#define MODULE_DEVICE_TABLE(type, name) \
|
#define MODULE_DEVICE_TABLE(type, name) \
|
||||||
extern const typeof(name) __mod_##type##__##name##_device_table \
|
extern typeof(name) __mod_##type##__##name##_device_table \
|
||||||
__attribute__ ((unused, alias(__stringify(name))))
|
__attribute__ ((unused, alias(__stringify(name))))
|
||||||
#else /* !MODULE */
|
#else /* !MODULE */
|
||||||
#define MODULE_DEVICE_TABLE(type, name)
|
#define MODULE_DEVICE_TABLE(type, name)
|
||||||
|
|
Loading…
Reference in a new issue