mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
ext4: remove unnecessary check from alloc_flex_gd()
[ Upstream commitb099eb87de
] In commit967ac8af44
("ext4: fix potential integer overflow in alloc_flex_gd()"), an overflow check is added to alloc_flex_gd() to prevent the allocated memory from being smaller than expected due to the overflow. However, after kmalloc() is replaced with kmalloc_array() in commit6da2ec5605
("treewide: kmalloc() -> kmalloc_array()"), the kmalloc_array() function has an overflow check, so the above problem will not occur. Therefore, the extra check is removed. Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20231023013057.2117948-3-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
474f5b00c5
commit
0cabe04c56
1 changed files with 0 additions and 3 deletions
|
@ -245,10 +245,7 @@ static struct ext4_new_flex_group_data *alloc_flex_gd(unsigned int flexbg_size)
|
||||||
if (flex_gd == NULL)
|
if (flex_gd == NULL)
|
||||||
goto out3;
|
goto out3;
|
||||||
|
|
||||||
if (flexbg_size >= UINT_MAX / sizeof(struct ext4_new_group_data))
|
|
||||||
goto out2;
|
|
||||||
flex_gd->count = flexbg_size;
|
flex_gd->count = flexbg_size;
|
||||||
|
|
||||||
flex_gd->groups = kmalloc_array(flexbg_size,
|
flex_gd->groups = kmalloc_array(flexbg_size,
|
||||||
sizeof(struct ext4_new_group_data),
|
sizeof(struct ext4_new_group_data),
|
||||||
GFP_NOFS);
|
GFP_NOFS);
|
||||||
|
|
Loading…
Reference in a new issue