mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
media: ti-vpe: Fix a missing check and reference count leak
[ Upstream commit7dae2aaaf4
] pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. And also, when the call of function vpe_runtime_get() failed, we won't call vpe_runtime_put(). Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails inside vpe_runtime_get(). Fixes:4571912743
("[media] v4l: ti-vpe: Add VPE mem to mem driver") Signed-off-by: Qiushi Wu <wu000273@umn.edu> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
a4c597c385
commit
0cb5c9607f
1 changed files with 2 additions and 0 deletions
|
@ -2470,6 +2470,8 @@ static int vpe_runtime_get(struct platform_device *pdev)
|
|||
|
||||
r = pm_runtime_get_sync(&pdev->dev);
|
||||
WARN_ON(r < 0);
|
||||
if (r)
|
||||
pm_runtime_put_noidle(&pdev->dev);
|
||||
return r < 0 ? r : 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue