mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
net: phy: sfp: hwmon: Fix scaling of RX power
The RX power read from the SFP uses units of 0.1uW. This must be
scaled to units of uW for HWMON. This requires a divide by 10, not the
current 100.
With this change in place, sensors(1) and ethtool -m agree:
sff2-isa-0000
Adapter: ISA adapter
in0: +3.23 V
temp1: +33.1 C
power1: 270.00 uW
power2: 200.00 uW
curr1: +0.01 A
Laser output power : 0.2743 mW / -5.62 dBm
Receiver signal average optical power : 0.2014 mW / -6.96 dBm
Reported-by: chris.healy@zii.aero
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 1323061a01
("net: phy: sfp: Add HWMON support for module sensors")
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
503d81d428
commit
0cea0e1148
1 changed files with 1 additions and 1 deletions
|
@ -517,7 +517,7 @@ static int sfp_hwmon_read_sensor(struct sfp *sfp, int reg, long *value)
|
|||
|
||||
static void sfp_hwmon_to_rx_power(long *value)
|
||||
{
|
||||
*value = DIV_ROUND_CLOSEST(*value, 100);
|
||||
*value = DIV_ROUND_CLOSEST(*value, 10);
|
||||
}
|
||||
|
||||
static void sfp_hwmon_calibrate(struct sfp *sfp, unsigned int slope, int offset,
|
||||
|
|
Loading…
Reference in a new issue