mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 07:13:34 +00:00
ceph: fix error handling in ceph_read_iter
In case __ceph_do_getattr returns an error and the retry_op in ceph_read_iter is not READ_INLINE, then it's possible to invoke __free_page on a page which is NULL, this naturally leads to a crash. This can happen when, for example, a process waiting on a MDS reply receives sigterm. Fix this by explicitly checking whether the page is set or not. Cc: stable@vger.kernel.org # 3.19+ Signed-off-by: Nikolay Borisov <kernel@kyup.com> Reviewed-by: Yan, Zheng <zyan@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This commit is contained in:
parent
4d73644bc3
commit
0d7718f666
1 changed files with 2 additions and 1 deletions
|
@ -1272,7 +1272,8 @@ static ssize_t ceph_read_iter(struct kiocb *iocb, struct iov_iter *to)
|
|||
statret = __ceph_do_getattr(inode, page,
|
||||
CEPH_STAT_CAP_INLINE_DATA, !!page);
|
||||
if (statret < 0) {
|
||||
__free_page(page);
|
||||
if (page)
|
||||
__free_page(page);
|
||||
if (statret == -ENODATA) {
|
||||
BUG_ON(retry_op != READ_INLINE);
|
||||
goto again;
|
||||
|
|
Loading…
Reference in a new issue