mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-24 01:41:39 +00:00
sdhci-pxav3: Fix runtime PM initialization
Commit bb691ae464
breaks boot on OLPC
XO-4, it hangs somewhere inside sdhci_add_host.
When pm_runtime_set_autosuspend_delay() was being called, the device's
usage counter was 0, causing the PM layer to runtime-suspend the
device. We then went on to call sdhci_add_host() on a suspended
device, which hung.
Fix this by making the driver consistent with the omap_hsmmc driver,
both in terms of runtime PM initialization and error handling. Now
the device is not runtime-suspended until we exit the probe routine.
Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Chris Ball <cjb@laptop.org>
This commit is contained in:
parent
5a36d6bcdf
commit
0dcaa2499b
1 changed files with 3 additions and 4 deletions
|
@ -287,18 +287,15 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
|
|||
}
|
||||
}
|
||||
|
||||
pm_runtime_set_active(&pdev->dev);
|
||||
pm_runtime_enable(&pdev->dev);
|
||||
pm_runtime_get_sync(&pdev->dev);
|
||||
pm_runtime_set_autosuspend_delay(&pdev->dev, PXAV3_RPM_DELAY_MS);
|
||||
pm_runtime_use_autosuspend(&pdev->dev);
|
||||
pm_suspend_ignore_children(&pdev->dev, 1);
|
||||
pm_runtime_get_noresume(&pdev->dev);
|
||||
|
||||
ret = sdhci_add_host(host);
|
||||
if (ret) {
|
||||
dev_err(&pdev->dev, "failed to add host\n");
|
||||
pm_runtime_forbid(&pdev->dev);
|
||||
pm_runtime_disable(&pdev->dev);
|
||||
goto err_add_host;
|
||||
}
|
||||
|
||||
|
@ -318,6 +315,8 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
|
|||
err_of_parse:
|
||||
err_cd_req:
|
||||
err_add_host:
|
||||
pm_runtime_put_sync(&pdev->dev);
|
||||
pm_runtime_disable(&pdev->dev);
|
||||
clk_disable_unprepare(clk);
|
||||
clk_put(clk);
|
||||
err_clk_get:
|
||||
|
|
Loading…
Reference in a new issue