serial: ucc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231110152927.70601-52-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2a0e8be950
commit
0e1ff92834
|
@ -1459,7 +1459,7 @@ out_free:
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int ucc_uart_remove(struct platform_device *ofdev)
|
||||
static void ucc_uart_remove(struct platform_device *ofdev)
|
||||
{
|
||||
struct uart_qe_port *qe_port = platform_get_drvdata(ofdev);
|
||||
|
||||
|
@ -1470,8 +1470,6 @@ static int ucc_uart_remove(struct platform_device *ofdev)
|
|||
of_node_put(qe_port->np);
|
||||
|
||||
kfree(qe_port);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id ucc_uart_match[] = {
|
||||
|
@ -1492,7 +1490,7 @@ static struct platform_driver ucc_uart_of_driver = {
|
|||
.of_match_table = ucc_uart_match,
|
||||
},
|
||||
.probe = ucc_uart_probe,
|
||||
.remove = ucc_uart_remove,
|
||||
.remove_new = ucc_uart_remove,
|
||||
};
|
||||
|
||||
static int __init ucc_uart_init(void)
|
||||
|
|
Loading…
Reference in New Issue