mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
net: axienet: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
3d2232f54d
commit
0f113b8117
1 changed files with 2 additions and 0 deletions
|
@ -1501,6 +1501,7 @@ static int axienet_of_probe(struct platform_device *op)
|
|||
lp->regs = of_iomap(op->dev.of_node, 0);
|
||||
if (!lp->regs) {
|
||||
dev_err(&op->dev, "could not map Axi Ethernet regs.\n");
|
||||
ret = -ENOMEM;
|
||||
goto nodev;
|
||||
}
|
||||
/* Setup checksum offload, but default to off if not specified */
|
||||
|
@ -1563,6 +1564,7 @@ static int axienet_of_probe(struct platform_device *op)
|
|||
np = of_parse_phandle(op->dev.of_node, "axistream-connected", 0);
|
||||
if (!np) {
|
||||
dev_err(&op->dev, "could not find DMA node\n");
|
||||
ret = -ENODEV;
|
||||
goto err_iounmap;
|
||||
}
|
||||
lp->dma_regs = of_iomap(np, 0);
|
||||
|
|
Loading…
Reference in a new issue