mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
gadgetfs: list_for_each_safe() misuse
really weirdly spelled "while the list is non-empty, pick its first element, remove it from the list and free it" kind of loop... Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
342827d7d1
commit
104bb37d3e
1 changed files with 3 additions and 6 deletions
|
@ -1569,20 +1569,18 @@ gadgetfs_setup (struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
|
|||
|
||||
static void destroy_ep_files (struct dev_data *dev)
|
||||
{
|
||||
struct list_head *entry, *tmp;
|
||||
|
||||
DBG (dev, "%s %d\n", __func__, dev->state);
|
||||
|
||||
/* dev->state must prevent interference */
|
||||
restart:
|
||||
spin_lock_irq (&dev->lock);
|
||||
list_for_each_safe (entry, tmp, &dev->epfiles) {
|
||||
while (!list_empty(&dev->epfiles)) {
|
||||
struct ep_data *ep;
|
||||
struct inode *parent;
|
||||
struct dentry *dentry;
|
||||
|
||||
/* break link to FS */
|
||||
ep = list_entry (entry, struct ep_data, epfiles);
|
||||
ep = list_first_entry (&dev->epfiles, struct ep_data, epfiles);
|
||||
list_del_init (&ep->epfiles);
|
||||
dentry = ep->dentry;
|
||||
ep->dentry = NULL;
|
||||
|
@ -1605,8 +1603,7 @@ static void destroy_ep_files (struct dev_data *dev)
|
|||
dput (dentry);
|
||||
mutex_unlock (&parent->i_mutex);
|
||||
|
||||
/* fds may still be open */
|
||||
goto restart;
|
||||
spin_lock_irq (&dev->lock);
|
||||
}
|
||||
spin_unlock_irq (&dev->lock);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue