mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
ASoC: cs42l42: Don't rely on GPIOD_OUT_LOW to set RESET initially low
[ Upstream commit a479b44ac0
]
The ACPI setting for a GPIO default state has higher priority than the
flag passed to devm_gpiod_get_optional() so ACPI can override the
GPIOD_OUT_LOW. Explicitly set the GPIO low when hard resetting.
Although GPIOD_OUT_LOW can't be relied on this doesn't seem like a
reason to stop passing it to devm_gpiod_get_optional(). So we still pass
it to state our intent, but can deal with it having no effect.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230913150012.604775-3-sbinding@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
cbc43ddd5c
commit
110e6f5750
1 changed files with 6 additions and 0 deletions
|
@ -2281,6 +2281,12 @@ int cs42l42_common_probe(struct cs42l42_private *cs42l42,
|
||||||
if (cs42l42->reset_gpio) {
|
if (cs42l42->reset_gpio) {
|
||||||
dev_dbg(cs42l42->dev, "Found reset GPIO\n");
|
dev_dbg(cs42l42->dev, "Found reset GPIO\n");
|
||||||
|
|
||||||
|
/*
|
||||||
|
* ACPI can override the default GPIO state we requested
|
||||||
|
* so ensure that we start with RESET low.
|
||||||
|
*/
|
||||||
|
gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
|
||||||
|
|
||||||
/* Ensure minimum reset pulse width */
|
/* Ensure minimum reset pulse width */
|
||||||
usleep_range(10, 500);
|
usleep_range(10, 500);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue