mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 19:07:52 +00:00
staging: rtl8188eu: use GFP_ATOMIC under spinlock
We're holding a spinlock here so we can't do sleeping allocations.
The call tree is:
rtw_sta_flush() <-- takes spin_lock_bh(&pstapriv->asoc_list_lock);
--> ap_free_sta()
--> rtw_clearstakey_cmd()
Originally these calls were rtw_zmalloc() and then we switched them to
kzalloc() in fadbe0cd52
('staging: rtl8188eu:Remove rtw_zmalloc(),
wrapper for kzalloc()') and that made the bugs show up for my static
checker. The original code was buggy as well but my static checker
couldn't parse it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a5bde3a163
commit
11306d1f20
1 changed files with 3 additions and 3 deletions
|
@ -1106,20 +1106,20 @@ u8 rtw_clearstakey_cmd(struct adapter *padapter, u8 *psta, u8 entry, u8 enqueue)
|
||||||
if (!enqueue) {
|
if (!enqueue) {
|
||||||
clear_cam_entry(padapter, entry);
|
clear_cam_entry(padapter, entry);
|
||||||
} else {
|
} else {
|
||||||
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_KERNEL);
|
ph2c = kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC);
|
||||||
if (ph2c == NULL) {
|
if (ph2c == NULL) {
|
||||||
res = _FAIL;
|
res = _FAIL;
|
||||||
goto exit;
|
goto exit;
|
||||||
}
|
}
|
||||||
|
|
||||||
psetstakey_para = kzalloc(sizeof(struct set_stakey_parm), GFP_KERNEL);
|
psetstakey_para = kzalloc(sizeof(struct set_stakey_parm), GFP_ATOMIC);
|
||||||
if (psetstakey_para == NULL) {
|
if (psetstakey_para == NULL) {
|
||||||
kfree(ph2c);
|
kfree(ph2c);
|
||||||
res = _FAIL;
|
res = _FAIL;
|
||||||
goto exit;
|
goto exit;
|
||||||
}
|
}
|
||||||
|
|
||||||
psetstakey_rsp = kzalloc(sizeof(struct set_stakey_rsp), GFP_KERNEL);
|
psetstakey_rsp = kzalloc(sizeof(struct set_stakey_rsp), GFP_ATOMIC);
|
||||||
if (psetstakey_rsp == NULL) {
|
if (psetstakey_rsp == NULL) {
|
||||||
kfree(ph2c);
|
kfree(ph2c);
|
||||||
kfree(psetstakey_para);
|
kfree(psetstakey_para);
|
||||||
|
|
Loading…
Reference in a new issue