mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 06:10:56 +00:00
irqchip/gic, gic-v3: Prevent GSI to SGI translations
commit544808f7e2
upstream. At the moment the GIC IRQ domain translation routine happily converts ACPI table GSI numbers below 16 to GIC SGIs (Software Generated Interrupts aka IPIs). On the Devicetree side we explicitly forbid this translation, actually the function will never return HWIRQs below 16 when using a DT based domain translation. We expect SGIs to be handled in the first part of the function, and any further occurrence should be treated as a firmware bug, so add a check and print to report this explicitly and avoid lengthy debug sessions. Fixes:64b499d8df
("irqchip/gic-v3: Configure SGIs as standard interrupts") Signed-off-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220404110842.2882446-1-andre.przywara@arm.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
5bba7c4171
commit
113cd44297
2 changed files with 12 additions and 0 deletions
|
@ -1466,6 +1466,12 @@ static int gic_irq_domain_translate(struct irq_domain *d,
|
||||||
if(fwspec->param_count != 2)
|
if(fwspec->param_count != 2)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
|
if (fwspec->param[0] < 16) {
|
||||||
|
pr_err(FW_BUG "Illegal GSI%d translation request\n",
|
||||||
|
fwspec->param[0]);
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
*hwirq = fwspec->param[0];
|
*hwirq = fwspec->param[0];
|
||||||
*type = fwspec->param[1];
|
*type = fwspec->param[1];
|
||||||
|
|
||||||
|
|
|
@ -1085,6 +1085,12 @@ static int gic_irq_domain_translate(struct irq_domain *d,
|
||||||
if(fwspec->param_count != 2)
|
if(fwspec->param_count != 2)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
|
if (fwspec->param[0] < 16) {
|
||||||
|
pr_err(FW_BUG "Illegal GSI%d translation request\n",
|
||||||
|
fwspec->param[0]);
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
*hwirq = fwspec->param[0];
|
*hwirq = fwspec->param[0];
|
||||||
*type = fwspec->param[1];
|
*type = fwspec->param[1];
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue