mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
spi: imx: Don't skip cleanup in remove's error path
Returning early in a platform driver's remove callback is wrong. In this
case the dma resources are not released in the error path. this is never
retried later and so this is a permanent leak. To fix this, only skip
hardware disabling if waking the device fails.
Fixes: d593574aff
("spi: imx: do not access registers while clocks disabled")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230306065733.2170662-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
864f0513a3
commit
11951c9e3f
1 changed files with 5 additions and 7 deletions
|
@ -1856,13 +1856,11 @@ static int spi_imx_remove(struct platform_device *pdev)
|
||||||
|
|
||||||
spi_unregister_controller(controller);
|
spi_unregister_controller(controller);
|
||||||
|
|
||||||
ret = pm_runtime_resume_and_get(spi_imx->dev);
|
ret = pm_runtime_get_sync(spi_imx->dev);
|
||||||
if (ret < 0) {
|
if (ret >= 0)
|
||||||
dev_err(spi_imx->dev, "failed to enable clock\n");
|
writel(0, spi_imx->base + MXC_CSPICTRL);
|
||||||
return ret;
|
else
|
||||||
}
|
dev_warn(spi_imx->dev, "failed to enable clock, skip hw disable\n");
|
||||||
|
|
||||||
writel(0, spi_imx->base + MXC_CSPICTRL);
|
|
||||||
|
|
||||||
pm_runtime_dont_use_autosuspend(spi_imx->dev);
|
pm_runtime_dont_use_autosuspend(spi_imx->dev);
|
||||||
pm_runtime_put_sync(spi_imx->dev);
|
pm_runtime_put_sync(spi_imx->dev);
|
||||||
|
|
Loading…
Reference in a new issue