mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
greybus: svc: use a common prefix for debugfs functions
Use the common gb_svc functions also for the recently added svc functions. Having a common prefix clearly signals where the code resides, something which improves readability and helps during debugging (e.g. stack traces). Note that all functions in svc.c except for these three use the common prefix with the exception of the pwr_debugfs callbacks (that still use *a* common prefix) and the attribute accessors (than can not have a common prefix due to some macro magic). Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
parent
d7ed7cbfe6
commit
12185197ea
1 changed files with 6 additions and 6 deletions
|
@ -546,7 +546,7 @@ static const struct file_operations pwrmon_debugfs_power_fops = {
|
|||
.read = pwr_debugfs_power_read,
|
||||
};
|
||||
|
||||
static void svc_pwrmon_debugfs_init(struct gb_svc *svc)
|
||||
static void gb_svc_pwrmon_debugfs_init(struct gb_svc *svc)
|
||||
{
|
||||
int i;
|
||||
size_t bufsize;
|
||||
|
@ -608,14 +608,14 @@ static void svc_pwrmon_debugfs_init(struct gb_svc *svc)
|
|||
debugfs_remove(dent);
|
||||
}
|
||||
|
||||
static void svc_debugfs_init(struct gb_svc *svc)
|
||||
static void gb_svc_debugfs_init(struct gb_svc *svc)
|
||||
{
|
||||
svc->debugfs_dentry = debugfs_create_dir(dev_name(&svc->dev),
|
||||
gb_debugfs_get());
|
||||
svc_pwrmon_debugfs_init(svc);
|
||||
gb_svc_pwrmon_debugfs_init(svc);
|
||||
}
|
||||
|
||||
static void svc_debugfs_exit(struct gb_svc *svc)
|
||||
static void gb_svc_debugfs_exit(struct gb_svc *svc)
|
||||
{
|
||||
debugfs_remove_recursive(svc->debugfs_dentry);
|
||||
kfree(svc->rail_names);
|
||||
|
@ -660,7 +660,7 @@ static int gb_svc_hello(struct gb_operation *op)
|
|||
return ret;
|
||||
}
|
||||
|
||||
svc_debugfs_init(svc);
|
||||
gb_svc_debugfs_init(svc);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
@ -1112,7 +1112,7 @@ void gb_svc_del(struct gb_svc *svc)
|
|||
* from the request handler.
|
||||
*/
|
||||
if (device_is_registered(&svc->dev)) {
|
||||
svc_debugfs_exit(svc);
|
||||
gb_svc_debugfs_exit(svc);
|
||||
gb_svc_watchdog_destroy(svc);
|
||||
input_unregister_device(svc->input);
|
||||
device_del(&svc->dev);
|
||||
|
|
Loading…
Reference in a new issue