mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 16:37:50 +00:00
staging: vc04_services: Remove stack hog issue from TODO
Since there is no vchiq function listed by "make checkstack" anymore, we can remove the stack hog issue from the TODO. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
ae8d5f464d
commit
121bdbf113
1 changed files with 2 additions and 7 deletions
|
@ -40,17 +40,12 @@ should properly handle a module unload. This also includes that all
|
||||||
resouces must be freed (kthreads, debugfs entries, ...) and global
|
resouces must be freed (kthreads, debugfs entries, ...) and global
|
||||||
variables avoided.
|
variables avoided.
|
||||||
|
|
||||||
5) Fix stack hog
|
5) Cleanup logging mechanism
|
||||||
|
|
||||||
Running make checkstack shows that vchiq_dump_service_use_state() has
|
|
||||||
an extensive stack usage. Maybe other functions are also affected.
|
|
||||||
|
|
||||||
6) Cleanup logging mechanism
|
|
||||||
|
|
||||||
The driver should probably be using the standard kernel logging mechanisms
|
The driver should probably be using the standard kernel logging mechanisms
|
||||||
such as dev_info, dev_dbg, and friends.
|
such as dev_info, dev_dbg, and friends.
|
||||||
|
|
||||||
7) Documentation
|
6) Documentation
|
||||||
|
|
||||||
A short top-down description of this driver's architecture (function of
|
A short top-down description of this driver's architecture (function of
|
||||||
kthreads, userspace, limitations) could be very helpful for reviewers.
|
kthreads, userspace, limitations) could be very helpful for reviewers.
|
||||||
|
|
Loading…
Reference in a new issue