mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
staging: vc04_services: update TODO file
There are no struct typedef remaining inside vc04_services/. Hence, remove the task from the TODO file. While at it, fix the items sequential numbering. Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> Link: https://lore.kernel.org/r/3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
072590cc4f
commit
12b31d07b0
1 changed files with 2 additions and 6 deletions
|
@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process.
|
|||
|
||||
The code in vchiq_bcm2835_arm.c should fit in the generic platform file.
|
||||
|
||||
12) Get rid of all the struct typedefs
|
||||
|
||||
Most structs are typedefd, it's not encouraged in the kernel.
|
||||
|
||||
13) Get rid of all non essential global structures and create a proper per
|
||||
11) Get rid of all non essential global structures and create a proper per
|
||||
device structure
|
||||
|
||||
The first thing one generally sees in a probe function is a memory allocation
|
||||
|
@ -92,6 +88,6 @@ for all the device specific data. This structure is then passed all over the
|
|||
driver. This is good practice since it makes the driver work regardless of the
|
||||
number of devices probed.
|
||||
|
||||
14) Clean up Sparse warnings from __user annotations. See
|
||||
12) Clean up Sparse warnings from __user annotations. See
|
||||
vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter"
|
||||
is never disclosed to userspace.
|
||||
|
|
Loading…
Reference in a new issue