mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()
[ Upstream commit26783d74cc
] The "req" struct is always added to the "wm831x->auxadc_pending" list, but it's only removed from the list on the success path. If a failure occurs then the "req" struct is freed but it's still on the list, leading to a use after free. Fixes:78bb3688ea
("mfd: Support multiple active WM831x AUXADC conversions") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
7ca7532388
commit
13b69e2dfd
1 changed files with 1 additions and 2 deletions
|
@ -98,11 +98,10 @@ static int wm831x_auxadc_read_irq(struct wm831x *wm831x,
|
||||||
wait_for_completion_timeout(&req->done, msecs_to_jiffies(500));
|
wait_for_completion_timeout(&req->done, msecs_to_jiffies(500));
|
||||||
|
|
||||||
mutex_lock(&wm831x->auxadc_lock);
|
mutex_lock(&wm831x->auxadc_lock);
|
||||||
|
|
||||||
list_del(&req->list);
|
|
||||||
ret = req->val;
|
ret = req->val;
|
||||||
|
|
||||||
out:
|
out:
|
||||||
|
list_del(&req->list);
|
||||||
mutex_unlock(&wm831x->auxadc_lock);
|
mutex_unlock(&wm831x->auxadc_lock);
|
||||||
|
|
||||||
kfree(req);
|
kfree(req);
|
||||||
|
|
Loading…
Reference in a new issue