mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
watchdog: Fix possible use-after-free in wdt_startup()
[ Upstream commit c08a6b31e4
]
This module's remove path calls del_timer(). However, that function
does not wait until the timer handler finishes. This means that the
timer handler may still be running after the driver's remove function
has finished, which would result in a use-after-free.
Fix by calling del_timer_sync(), which makes sure the timer handler
has finished, and unable to re-schedule itself.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/1620716495-108352-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1e6e806dda
commit
146cc288fb
1 changed files with 1 additions and 1 deletions
|
@ -146,7 +146,7 @@ static void wdt_startup(void)
|
|||
static void wdt_turnoff(void)
|
||||
{
|
||||
/* Stop the timer */
|
||||
del_timer(&timer);
|
||||
del_timer_sync(&timer);
|
||||
inb_p(wdt_stop);
|
||||
pr_info("Watchdog timer is now disabled...\n");
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue