mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 22:26:55 +00:00
staging: pi433: change order in which driver config the rf69 chip
There is an explicit dependency between modulation and bit rate configurations. To ensure proper validation of input value for the set_bit_rate routine, we must ensure that modulation has been set before. This patch ensures that set_modulation is always called before set_bit_rate for both RX and TX routines Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> Link: https://lore.kernel.org/r/20220118230502.GA4897@mail.google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
d9dc6c1b44
commit
14dbdad1f1
1 changed files with 4 additions and 4 deletions
|
@ -164,10 +164,10 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg)
|
|||
ret = rf69_set_frequency(dev->spi, rx_cfg->frequency);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_bit_rate(dev->spi, rx_cfg->bit_rate);
|
||||
ret = rf69_set_modulation(dev->spi, rx_cfg->modulation);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_modulation(dev->spi, rx_cfg->modulation);
|
||||
ret = rf69_set_bit_rate(dev->spi, rx_cfg->bit_rate);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_antenna_impedance(dev->spi, rx_cfg->antenna_impedance);
|
||||
|
@ -287,10 +287,10 @@ rf69_set_tx_cfg(struct pi433_device *dev, struct pi433_tx_cfg *tx_cfg)
|
|||
ret = rf69_set_frequency(dev->spi, tx_cfg->frequency);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_bit_rate(dev->spi, tx_cfg->bit_rate);
|
||||
ret = rf69_set_modulation(dev->spi, tx_cfg->modulation);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_modulation(dev->spi, tx_cfg->modulation);
|
||||
ret = rf69_set_bit_rate(dev->spi, tx_cfg->bit_rate);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = rf69_set_deviation(dev->spi, tx_cfg->dev_frequency);
|
||||
|
|
Loading…
Reference in a new issue