mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
sfc: fix return value check in efx_ptp_probe_channel()
In case of error, the function ptp_clock_register() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Reviewed-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
228fb087a0
commit
155d940a78
1 changed files with 3 additions and 1 deletions
|
@ -912,8 +912,10 @@ static int efx_ptp_probe_channel(struct efx_channel *channel)
|
||||||
|
|
||||||
ptp->phc_clock = ptp_clock_register(&ptp->phc_clock_info,
|
ptp->phc_clock = ptp_clock_register(&ptp->phc_clock_info,
|
||||||
&efx->pci_dev->dev);
|
&efx->pci_dev->dev);
|
||||||
if (!ptp->phc_clock)
|
if (IS_ERR(ptp->phc_clock)) {
|
||||||
|
rc = PTR_ERR(ptp->phc_clock);
|
||||||
goto fail3;
|
goto fail3;
|
||||||
|
}
|
||||||
|
|
||||||
INIT_WORK(&ptp->pps_work, efx_ptp_pps_worker);
|
INIT_WORK(&ptp->pps_work, efx_ptp_pps_worker);
|
||||||
ptp->pps_workwq = create_singlethread_workqueue("sfc_pps");
|
ptp->pps_workwq = create_singlethread_workqueue("sfc_pps");
|
||||||
|
|
Loading…
Reference in a new issue