list_debug: WARN for adding something already in the list

We were bitten by this at one point and added an additional sanity test
for DEBUG_LIST.  You can't validly add a list_head to a list where either
prev or next is the same as the thing you're adding.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Chris Metcalf 2012-05-29 15:07:31 -07:00 committed by Linus Torvalds
parent 401dea7f7a
commit 17a801f4bf
1 changed files with 3 additions and 0 deletions

View File

@ -31,6 +31,9 @@ void __list_add(struct list_head *new,
"list_add corruption. prev->next should be " "list_add corruption. prev->next should be "
"next (%p), but was %p. (prev=%p).\n", "next (%p), but was %p. (prev=%p).\n",
next, prev->next, prev); next, prev->next, prev);
WARN(new == prev || new == next,
"list_add double add: new=%p, prev=%p, next=%p.\n",
new, prev, next);
next->prev = new; next->prev = new;
new->next = next; new->next = next;
new->prev = prev; new->prev = prev;