mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
media: sun8i_rotate: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
parent
98e3987ae6
commit
17d32ccde1
1 changed files with 2 additions and 4 deletions
|
@ -833,7 +833,7 @@ static int rotate_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int rotate_remove(struct platform_device *pdev)
|
||||
static void rotate_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct rotate_dev *dev = platform_get_drvdata(pdev);
|
||||
|
||||
|
@ -842,8 +842,6 @@ static int rotate_remove(struct platform_device *pdev)
|
|||
v4l2_device_unregister(&dev->v4l2_dev);
|
||||
|
||||
pm_runtime_force_suspend(&pdev->dev);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int rotate_runtime_resume(struct device *device)
|
||||
|
@ -907,7 +905,7 @@ static const struct dev_pm_ops rotate_pm_ops = {
|
|||
|
||||
static struct platform_driver rotate_driver = {
|
||||
.probe = rotate_probe,
|
||||
.remove = rotate_remove,
|
||||
.remove_new = rotate_remove,
|
||||
.driver = {
|
||||
.name = ROTATE_NAME,
|
||||
.of_match_table = rotate_dt_match,
|
||||
|
|
Loading…
Reference in a new issue