mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
misc: open-dice: Fix spurious lockdep warning
[ Upstream commit ac9762a74c
]
When probing the open-dice driver with PROVE_LOCKING=y, lockdep
complains that the mutex in 'drvdata->lock' has a non-static key:
| INFO: trying to register non-static key.
| The code is fine but needs lockdep annotation, or maybe
| you didn't initialize this object before use?
| turning off the locking correctness validator.
Fix the problem by initialising the mutex memory with mutex_init()
instead of __MUTEX_INITIALIZER().
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: David Brazdil <dbrazdil@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20240126152410.10148-1-will@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1c57e5ef85
commit
17fe3616d8
1 changed files with 1 additions and 1 deletions
|
@ -142,7 +142,6 @@ static int __init open_dice_probe(struct platform_device *pdev)
|
||||||
return -ENOMEM;
|
return -ENOMEM;
|
||||||
|
|
||||||
*drvdata = (struct open_dice_drvdata){
|
*drvdata = (struct open_dice_drvdata){
|
||||||
.lock = __MUTEX_INITIALIZER(drvdata->lock),
|
|
||||||
.rmem = rmem,
|
.rmem = rmem,
|
||||||
.misc = (struct miscdevice){
|
.misc = (struct miscdevice){
|
||||||
.parent = dev,
|
.parent = dev,
|
||||||
|
@ -152,6 +151,7 @@ static int __init open_dice_probe(struct platform_device *pdev)
|
||||||
.mode = 0600,
|
.mode = 0600,
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
mutex_init(&drvdata->lock);
|
||||||
|
|
||||||
/* Index overflow check not needed, misc_register() will fail. */
|
/* Index overflow check not needed, misc_register() will fail. */
|
||||||
snprintf(drvdata->name, sizeof(drvdata->name), DRIVER_NAME"%u", dev_idx++);
|
snprintf(drvdata->name, sizeof(drvdata->name), DRIVER_NAME"%u", dev_idx++);
|
||||||
|
|
Loading…
Reference in a new issue